[tarantool-patches] Re: [PATCH v2 3/3] sql: enable multi-engine tests for SQL
- From: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>
- To: tarantool-patches@xxxxxxxxxxxxx
- Date: Mon, 2 Jul 2018 11:46:03 +0300
Could we disable them for vinyl somehow and run only once?
Some of them take long time to execute.
This way:
+++ b/test/sql-tap/engine.cfg
@@ -1,4 +1,7 @@
{
+ "analyze9.test.lua": {
+ "memtx": {"engine": "memtx"}
+ },
"*": {
"memtx": {"engine": "memtx"},
"vinyl": {"engine": "vinyl"}
+++ b/test/sql-tap/analyze9.test.lua
- pragma sql_default_engine='memtx';
Lets put newline at the end of file.
Ok, fixed on merge.
Please, use types for columns: we are going to introduce static types
in SQL and make them mandatory.
-box.sql.execute("CREATE TABLE t1_vinyl(a primary key,b,c);")
-box.sql.execute("CREATE TABLE t2_vinyl(a primary key,b,c);")
+box.sql.execute("CREATE TABLE t1_vinyl(a INT PRIMARY KEY, b INT, c INT);")
+box.sql.execute("CREATE TABLE t2_vinyl(a INT PRIMARY KEY, b INT, c INT);")
-box.sql.execute("CREATE TABLE t3_memtx(a primary key,b,c);")
+box.sql.execute("CREATE TABLE t3_memtx(a INT PRIMARY KEY, b INT, c INT);")
Other related posts:
