[tarantool-patches] Re: [PATCH v1 2/2] sql: remove OP_LoadPtr

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Tue, 10 Jul 2018 17:59:14 +0300

Thanks for finishing the patch! I have force pushed more deletions
on the branch.

On 10/07/2018 16:45, Kirill Shcherbatov wrote:

From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>

This opcode was used when Vdbe had to store key_def in P4 for
OP_OpenRead/Write, so P4 was occupied and OP_LoadPtr was used to
store space pointer in another opcode. But now P4 is free for
OpenRead/Write and space pointer can be stored here.

Alongside, some useless key_def duplications are removed.
---
  src/box/sql/analyze.c |  8 ++------
  src/box/sql/build.c   | 20 ++++++--------------
  src/box/sql/delete.c  | 16 ++--------------
  src/box/sql/insert.c  | 18 ++++--------------
  src/box/sql/pragma.c  | 15 +++++++++++----
  src/box/sql/vdbe.c    | 41 ++++++-----------------------------------
  6 files changed, 31 insertions(+), 87 deletions(-)


Other related posts: