[tarantool-patches] Re: [PATCH v1 1/2] sql: use schema API to get index info in analyze

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Wed, 25 Jul 2018 23:52:21 +0300

Hi! Thanks for the patch, but it is not needed anymore
after this commit
https://github.com/tarantool/tarantool/commit/0ecabde8981500886bf5be16cfabe4d1d1a33db4.

Moreover, we should stop use schema_find_id to get a space since
such requests should be filtered through _vspace to prevent
unauthorized access to _space. I've opened an issue:
https://github.com/tarantool/tarantool/issues/3570

On 24/07/2018 14:05, Kirill Shcherbatov wrote:

We would like to avoid starting transactions in ANALYZE
so we need to use schema API that is more tolerant.

Part of #3551.
---
  src/box/sql/analyze.c | 82 ++++++++++++++++++++++++++++++---------------------
  1 file changed, 48 insertions(+), 34 deletions(-)


Other related posts:

  1. Home
  2. tarantool-patches
  3. Archive
  4. 07-2018