[tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack BLOB on select
- From: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>
- To: tarantool-patches@xxxxxxxxxxxxx, Nikita Pettik <korablev@xxxxxxxxxxxxx>
- Date: Tue, 3 Jul 2018 17:02:46 +0300
Hello. Thanks for the patch! I have pushed my fixes on the
branch in a separate commit. Please, look and squash if you
are ok with it.
Tnx. Ok for me, excluding this:
+++ b/src/box/sql/vdbeapi.c
@@ -224,8 +224,7 @@ sqlite3_value_int64(sqlite3_value * pVal)
enum sql_subtype
sqlite3_value_subtype(sqlite3_value * pVal)
{
- Mem *pMem = (Mem *) pVal;
- return (pMem->flags & MEM_Subtype) != 0 ? pMem->subtype : 0;
+ return (pVal->flags & MEM_Subtype) != 0 ? pVal->subtype : SQL_SUBTYPE_NO;
}
on head "review review fixes"
Nikita, please, look at my changes too, they are not minor.
Other related posts: