[tarantool-patches] Re: [PATCH v1 1/1] sql: refactor vdbe_emit_open_cursor calls

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx, Nikita Pettik <korablev@xxxxxxxxxxxxx>
  • Date: Tue, 10 Jul 2018 19:52:38 +0300

Thanks for the squash. I have force pushed some comment
style violation fixes.

Nikita, please, do a second review.

On 10/07/2018 19:37, Kirill Shcherbatov wrote:

Maybe it is more convenient, but it is not more correct. Your
first commit still does not fix the mess with index_id/tnum.

Please, squash it into your first commit.
Ok, I've done this.


Other related posts:

  1. Home
  2. tarantool-patches
  3. Archive
  4. 07-2018