[tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Thu, 12 Jul 2018 11:54:49 +0300

Hello. Thanks for the patch!

I know, that removal of assertion always 'fixes' it, but please,
either fix it without removal (and for me it is not obvious why it
should be removed), or explain, why it is invalid.

On 12/07/2018 09:30, Kirill Shcherbatov wrote:

Close #3522.
---
https://github.com/tarantool/tarantool/compare/kshch/gh-3522-invalid-primary-key-column-name
https://github.com/tarantool/tarantool/issues/3522

  src/box/sql/build.c                   | 1 -
  test/sql/gh-2929-primary-key.result   | 7 +++++++
  test/sql/gh-2929-primary-key.test.lua | 5 +++++
  3 files changed, 12 insertions(+), 1 deletion(-)


Other related posts: