[tarantool-patches] Re: [PATCH v1 1/1] sql: disallow division by zero

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Mon, 16 Jul 2018 13:31:04 +0300

Thanks for the fixes!

LGTM.

On 13/07/2018 14:49, Kirill Shcherbatov wrote:

Hi! Thank you for review.

1. Typo.
Fixed.

2. Garbage comment.Dropped. It wasn't mine.

3. Such huge test for division by zero is overkill. Please, fix the test to
avoid division by zero. Obviously it was not about divisions.
Ok, I've changed one sign to fix this test case:
return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct 
(abs((abs(c)/abs(c)))/abs((abs(11)/abs(+case  .....
return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct 
(abs((abs(c)/abs(c)))/abs((abs(11)*abs(+case  .....
Test result didn't change.


Other related posts:

  1. Home
  2. tarantool-patches
  3. Archive
  4. 07-2018