[tarantool-patches] Re: [PATCH v1 1/1] lib/bitset: rename bitset structs

  • From: Konstantin Osipov <kostja@xxxxxxxxxxxxx>
  • To: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
  • Date: Tue, 3 Jul 2018 20:10:34 +0300

* Vladimir Davydov <vdavydov.dev@xxxxxxxxx> [18/07/03 19:29]:

On Tue, Jul 03, 2018 at 04:24:36PM +0300, Kirill Shcherbatov wrote:
I don't think you should rename any structures or functions defined in
memtx_bitset.c - they don't conflict and they are not related to struct
bitset.

Changes in memtx_bitset.{c, h} with my patch now.

Technically, the patch looks fine to me. Kostja, does renaming struct
bitset to tt_bitset in order to fix FreeBSD build make sense to you,
or you have a better idea in mind?

No, I haven't. We can rename again when we get a better idea.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

Other related posts:

  1. Home
  2. tarantool-patches
  3. Archive
  4. 07-2018