LGTM. Nikita, please, make a second review.
On 04/07/2018 20:17, Kirill Shcherbatov wrote:
As we are going to implement parser as separate library,
we should get rid off sqlite3NestedParse calls.
Last usages in statistics update could be trivially rewrited
to do not start parsing. We manually build AST structures
simmilar to parser did and manually call sql_table_delete_from.
Finilly, I've removed all sqlite3NestedParse mentionings.
Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3496-no-nested-parse
Issue: https://github.com/tarantool/tarantool/issues/3496
Kirill Shcherbatov (2):
sql: get rid off sqlite3NestedParse in clean stats
sql: remove usless sqlite3NestedParse function
src/box/sql/analyze.c | 39 ++++++++--------
src/box/sql/build.c | 122 ++++++++++++++++++++++++------------------------
src/box/sql/delete.c | 6 +--
src/box/sql/insert.c | 6 +--
src/box/sql/sqliteInt.h | 14 +++++-
src/box/sql/update.c | 6 +--
6 files changed, 97 insertions(+), 96 deletions(-)
