[tarantool-patches] Re: [PATCH] sql: remove support of partial indexes from parser

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: "n.pettik" <korablev@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Mon, 2 Jul 2018 21:30:22 +0300

LGTM.

On 02/07/2018 18:51, n.pettik wrote:


1. The error is caused by typo in the request, not by lack of
partial indexes.

Forgot to place ‘;’ at the end of statement:

@@ -291,14 +291,16 @@ test:do_eqp_test(
          -- </index7-6.4>
      })
+-- gh-2165 Currently, Tarantool lacks support of partial indexes,
+-- so temporary we removed processing of their syntax from parser.
+--
  test:do_catchsql_test(
-    "index7-6.5",
+    "index7-7.1",
      [[
-        CREATE INDEX t5a ON t5(a) WHERE a=#1;
+        CREATE TABLE t1 (a INTEGER PRIMARY KEY, b INTEGER);
+        CREATE UNIQUE INDEX i ON t1 (a) WHERE a = 3;
      ]], {
-        -- <index7-6.5>
-        1, [[near "#1": syntax error]]
-        -- </index7-6.5>
+        1, "keyword \"WHERE\" is reserved"


Other related posts: