[tarantool-patches] Re: [PATCH] msgpackffi.decode can now be assigned to buf.rpos
- From: Alexander Turenko <alexander.turenko@xxxxxxxxxxxxx>
- To: Kirill Yukhin <kyukhin@xxxxxxxxxxxxx>
- Date: Tue, 31 Dec 2019 06:56:07 +0300
On Mon, Dec 30, 2019 at 10:53:26AM +0300, Kirill Yukhin wrote:
Hello,
On 12 сен 20:44, Maria wrote:
Function decode of module msgpackffi was passing
value of type const unsigned char * to a C function
that accepts arguments of type const char *.
Closes #3926
Test added
---
src/lua/msgpackffi.lua | 8 +++++---
test/app-tap/msgpackffi.test.lua | 6 ++++++
2 files changed, 11 insertions(+), 3 deletions(-)
I've checked your patch into master.
I would reconsider it as bug and push everywhere (both patches).
It seems that significant part of the problem is just because someone
forgot to cast (unsigned char *) back to (char *) before returning.
What do you think, Kirill?
WBR, Alexander Turenko.
Other related posts: