[tarantool-patches] Re: [PATCH] Do not update schema_version on space:truncate().
- From: Konstantin Osipov <kostja@xxxxxxxxxxxxx>
- To: Sergey Petrenko <sergepetrenko@xxxxxxxxxxxxx>
- Date: Fri, 6 Jul 2018 17:29:06 +0300
* Sergey Petrenko <sergepetrenko@xxxxxxxxxxxxx> [18/07/06 17:27]:
Will fix. I thought it'd be a good idea to only increment when we already
know
we won't be returning to the old state.
So I should increase schema_version in UpdateSchemaVersion::alter() and
decrease it in
UpdateSchemaVersion::rollback() ?
Never decrement. Reloading a schema extra time won't break
anything.
And what about creation/drop of a space?
Move
schema_version increment to on_replace_dd_space()
OK.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
Other related posts:
