[tarantool-patches] Re: [PATCH 3/3] test: slab_arena -- Verify madvise
- From: Alexander Turenko <alexander.turenko@xxxxxxxxxxxxx>
- To: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
- Date: Mon, 6 May 2019 14:04:48 +0300
On Mon, May 06, 2019 at 01:45:20PM +0300, Vladimir Davydov wrote:
[Cc += Alexander re tests]
On Wed, May 01, 2019 at 06:50:06PM +0300, Cyrill Gorcunov wrote:
Since madvise support depends on sys libraries
and kernel version we print error if only small
supports it and /proc/self/smaps provide more
less decent VmFlags.
TBO I wouldn't bother testing this feature at all, because it's way too
platform dependent.
Alternatively, we could test it by crashing a process and checking the
size of the generated core file, but then again it doesn't look like a
portable way.
Alexander, any ideas?
I think it is okay to test a platform-specific feature only on a
platform where it is supported, but skip the test otherwise.
We only need to ensure our check whether the feature is supported is
reliable. Travis-CI for small checks all (or almost all) supported
distros, but lack of Mac OS target. It worth to check it on Mac OS (and
maybe on FreeBSD) via CI or at least manually.
Other related posts:
