LGTM.
04.04.2018 21:11, n.pettik пишет:
On 3 Apr 2018, at 21:27, Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx <mailto:v.shpilevoy@xxxxxxxxxxxxx>> wrote:
See 6 comments below.
03.04.2018 19:14, Nikita Pettik пишет:
As a part of SQL data dictionary integration, 'DROP INDEX' and
'DROP TABLE' statements proccessing has been refactored in order
to avoid using SQL specific internal structures.
However, triggers still aren't transfered to server, so to drop them
it is required to lookup SQL table and emit apporpriate opcodes.
Also, added comments and fixed codestyle for functions processing
'DROP' routine.
Part of #3222.
---
src/box/sql/build.c | 241 ++++++++++++++++++++++++++----------------------
src/box/sql/parse.c | 6 +-
src/box/sql/parse.y | 6 +-
src/box/sql/sqliteInt.h | 6 +-
4 files changed, 140 insertions(+), 119 deletions(-)
