[tarantool-patches] Re: [PATCH 1/2] test: wait until expected value appear in log
- From: Alexander Turenko <alexander.turenko@xxxxxxxxxxxxx>
- To: Sergei Voronezhskii <sergw@xxxxxxxxxxxxx>
- Date: Sun, 21 Oct 2018 07:40:32 +0300
fio.basename(snaps[1], '.snap') >= fio.basename(xlogs[1], '.xlog')
-- gh-2780 check that scheduled snapshots are performed
-fiber.sleep(3 * PERIOD)
--- check that it's not first snapshot
-test_run:grep_log("default", "saving snapshot", 400) == nil
-test_run:grep_log("default", "making snapshot", 400) ~= nil
+test_run:wait_log("default", "making snapshot", 400, 1.0 + PERIOD)
-- restore default options
box.cfg{checkpoint_interval = 3600 * 4, checkpoint_count = 4 }
Cite from the previous review:
-- gh-2780 check that scheduled snapshots are performed
-fiber.sleep(3 * PERIOD)
-- check that it's not first snapshot
-test_run:grep_log("default", "saving snapshot", 400) == nil
-test_run:grep_log("default", "making snapshot", 400) ~= nil
+wait_cond(function() return test_run:grep_log("default", "saving
snapshot", 400) == nil end)
+wait_cond(function() return test_run:grep_log("default", "making
snapshot", 400) ~= nil end)
Now we don't check that 'saving snapshot' does not appear during some
time period. Maybe we should check it after 'making snapshot'.
It seems you decided to remove the check for some reason you don't mention in
the commit message. Am I missed something obvious?
In the previous message I just stated that **your** (previous) version of the
patch does not check for 'saving snapshot' while the original case does.
WBR, Alexander Turenko.
Other related posts:
