[tarantool-patches] Re: [PATCH 0/3] Syslog destination
- From: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
- To: Olga Arkhangelskaia <arkholga@xxxxxxxxxxxxx>
- Date: Fri, 13 Jul 2018 15:42:32 +0300
On Fri, Jul 13, 2018 at 01:29:35PM +0300, Olga Arkhangelskaia wrote:
This series adds support of configurable destionation for syslog.
The option is called server. Possible options are ip4 and unix socket:
syslog:server=unix:/path/to/socket,identity=myinstance
syslog:server=ip4:port,identity=tarantool_myinstance
If server option is not set, but syslog is used in log configuration -
default sockets for syslogd are used: /dev/log or /var/run/syslog.
This series is upon fix #3205. That will be slightly changed later.
Closes #3487
--OKriw/gh-3487-syslog-conf-dest
Please put hyperlinks to both the branch and the issue in the cover
letter (or in the patch after --- if there's none). In your case it
would be:
https://github.com/tarantool/tarantool/issues/3487
https://github.com/tarantool/tarantool/commits/OKriw/gh-3487-syslog-conf-dest
BTW app-tap/syslog_remote.test.lua fails on Travis:
https://travis-ci.org/tarantool/tarantool/jobs/403493458
https://travis-ci.org/tarantool/tarantool/builds/403493456?utm_source=github_status&utm_medium=notification
Please fix.
Also, please add the email you use for committing patches to your GitHub
profile so that your commits are authored correctly in GitHub.
Olga Arkhangelskaia (3):
Configurable syslog destination
We typically prefix the subjet line with the subsystem name, in your
case it would be 'say: '.
Syslog remote destination test
Syslog destination test unix socket
In this particular case, it isn't worth submitting tests separately.
Please fold them in the main patch.
src/say.c | 76
+++++++++++++++++++++++++++++++++----
src/say.h | 7 ++++
test/app-tap/syslog_remote.test.lua | 33 ++++++++++++++++
test/app-tap/syslog_socket.test.lua | 33 ++++++++++++++++
4 files changed, 141 insertions(+), 8 deletions(-)
create mode 100755 test/app-tap/syslog_remote.test.lua
create mode 100755 test/app-tap/syslog_socket.test.lua
Other related posts:
