[racktables-users] Suggested patch to inc/interface.php
- From: Mike Gracy <ghstridr@xxxxxxxxx>
- To: racktables-users@xxxxxxxxxxxxx
- Date: Fri, 14 May 2010 19:42:56 -0700
I've been staring at this minor cosmetic annoyance for a while(since
0.17.7) and finally decided to do something about it.
When on the Ports tab of a switch's property page, when you go to link
a device to a port...this window pops up with everything close to it
(usually what's in the rack). This is a great feature. The annoyance
(for me) is that the 'Link' button is mostly cut off by the edge of
the browser window. I've experienced this in numerous versions of
firefox (never bothered with IE as I'm on linux). So I increased the
height of the window (works beautifully now!). So here is a patch for
that file:
--- interface.php.orig 2010-05-14 19:19:34.000000000 -0700
+++ interface.php 2010-05-14 19:19:57.000000000 -0700
@@ -1195,7 +1195,7 @@
'port' => $port['id'],
'in_rack' => 'n',
);
- $popup_args = 'height=700, width=400,
location=no, menubar=no, '.
+ $popup_args = 'height=750, width=400,
location=no, menubar=no, '.
'resizable=yes, scrollbars=no,
status=no, titlebar=no, toolbar=no';
echo " ondblclick='window.open(\"" .
makeHrefForHelper ('portlist', $helper_args);
echo "\",\"findlink\",\"${popup_args}\");'";
---EOF---
I don't know if this list will accept attachments, but I don't think
it's that big of a deal with a one line edit.
This is the joy of open source, if you don't like the way it works,
fix/change it and submit a patch as others might like it too!
Other related posts:
