[procps] Re: [pull] two weeks of fixes
- From: Sami Kerola <kerolasa@xxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Mon, 6 Feb 2012 17:38:17 +0100
On Mon, Feb 6, 2012 at 16:23, Jim Warner <james.warner@xxxxxxxxxxx> wrote:
> On Feb 5, 2012, at 4:29 PM, Sami Kerola wrote:
>
>> usage [smatch scan]
>> vmstat: open file should be closed, not freed
>> top: initialize rbuf variable [cppscan]
>> libprocps: open file should be closed, not freed
>
> Could you please discard that top change.
>
> It makes no sense to trade a simple store instruction for the memset function
> call overhead.
Hi Jim,
The patch is nuked.
--
Sami Kerola
http://www.iki.fi/kerolasa/
Other related posts:
