[procps] Re: procps-ng 3.3.9 defects found
- From: Jaromir Capik <jcapik@xxxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Tue, 3 Dec 2013 16:08:50 -0500 (EST)
> > The following problems were found during the procps-ng-3.3.9
> > quality assurance scans:
> > ----------
> > procps-ng-3.3.9/top/top.c:3449:error[invalidScanfFormatWidth] – Width 80
> > given in format string (no. 2) is larger than destination buffer
> > 'fieldscur[80]', use %79s to prevent overflowing it.
> > ----------
> > procps-ng-3.3.9/sysctl.c:649:error[memleak] – Memory leak: cfgs
> > ----------
> > procps-ng-3.3.9/proc/whattime.c:77:error[uninitvar] – Uninitialized
> > variable: pos
> > ----------
> > procps-ng-3.3.9/pgrep.c:468:error[memleak] – Memory leak: re
> > ----------
> >
> > Any volunteers? :]
>
> Hi Jaromir,
Hi Jim :]
> I'll deal with the top issue but I don't consider it critical.
>
> The actual contents cannot currently exceed 70 + 1 bytes.
>
> I am puzzled, though, over why this did not arise before.
>
> Are you using new/improved tools?
Sure ... the guys are working really hard to make the tests
absolutely bulletproof. We REALLY want to offer excellent
quality products. And we hope it has a positive impact
on all included software products :]
The uninitialized 'pos' is also harmless, but the bug is there
and I'll fix it by moving the increment to the body of the next
condition.
> Regards,
>
> Jim
>
Regards,
Jaromir.
>
>
>
Other related posts:
