[pisa] Quick and dirty fix to disable adding of default route for pisacd
- From: David Martin <david.martin.mailbox@xxxxxxxxxxxxxx>
- To: pisa <pisa@xxxxxxxxxxxxx>
- Date: Tue, 24 May 2011 18:01:04 +0200
Hi,
some have been having problems registering with the PISA server daemon
running on morpheus. The register packets gets sent but the ACK is
never received. Hanno suggested removing the default route as received
packets get directly routed to the pisatunnel again. I have attached a
patch that crudely comments out the parts of the code responsible for
setup and deletion of the default route. This is no real solution and
should _not_ be committed but for the time being it fixes the
connection problem on the affected devices like the N900.
In the root directory of the pisa trunk apply with
patch -p0 -i ignore_default_route.patch
and revert with
patch -p0 -i ignore_default_route.patch -R
or
svn revert pisacd/cdregister.c pisacd/cdderegister.c
David
Index: pisacd/cdderegister.c
===================================================================
--- pisacd/cdderegister.c (revision 2586)
+++ pisacd/cdderegister.c (working copy)
@@ -30,11 +30,12 @@
*/
static void pisa_remove_default_route(void)
{
- const char *delete_default_route = "route del default";
- PISA_DEBUG(PL_GENERIC, "remove default route\n");
- if (system(delete_default_route) < 0) {
- PISA_ERROR("ERROR: %s: Can't delete default route!\n", __FUNCTION__);
- }
+ PISA_DEBUG(PL_GENERIC, "Not removing the default route.\n");
+ //const char *delete_default_route = "route del default";
+ //PISA_DEBUG(PL_GENERIC, "remove default route\n");
+ //if (system(delete_default_route) < 0) {
+ // PISA_ERROR("ERROR: %s: Can't delete default route!\n", __FUNCTION__);
+ //}
}
/**
Index: pisacd/cdregister.c
===================================================================
--- pisacd/cdregister.c (revision 2586)
+++ pisacd/cdregister.c (working copy)
@@ -138,7 +138,8 @@
char buffer[1024] = {0}, ip[INET_ADDRSTRLEN];
inet_ntop(AF_INET, ipv4, ip, sizeof(ip));
- snprintf(buffer, sizeof(buffer), "route add default gw %s", ip);
+ PISA_DEBUG(PL_GENERIC, "Explicitly not adding the default route via
%s.\n", ip);
+ //snprintf(buffer, sizeof(buffer), "route add default gw %s", ip);
if (system(buffer) < 0) {
PISA_ERROR("Can't add default route!\n");
}
Other related posts:
- » [pisa] Quick and dirty fix to disable adding of default route for pisacd - David Martin
