[pisa] Re: Bug in hipd

  • From: Dongsu Park <Dongsu.Park@xxxxxxxxxxxxxx>
  • To: pisa@xxxxxxxxxxxxx
  • Date: Wed, 17 Sep 2008 10:25:42 +0200

Wolfram Fischer wrote:
Hi Dongsu,

sorry, there has been an another bug in my patch 151. I resolved it and
committed as patch-152. Try to test it with '--disable-privsep'. I'm
sure you'll get no problem any more.

Will give it a try on Friday, thank you very much for your efforts!
Could you find an explanation for the bug?
If it would be helpfull, I could give you logins to my VBoxes for
debugging this stuff.

Hi Wolfram,

Actually there was two reasons for this bug. One was the capability issue, which you can avoid by --disable-privsep. The another was my fault in my patch 151.

In my patch, I wanted to add a new action 'handover' for hipconf command and tried to add definitions and modify existing data structures, but it was not sufficient. I should have defined TYPE_HANDOVER with the right value in libinet6/hipconf.h. So it broke the consistency not only for hipconf but also for hipd, because hipd automatically loads its own configurations from /etc/hip/hipd_config and set them with hipconf.

Unfortunately I didn't know what I should do exactly for adding a new hipconf action, because no document told me about that. The only document for hipl developers is doc/HACKING, but no such contents were in it. That's actually why we do the same mistake. So yesterday in doc/HACKING I added a section 'Adding hipconf actions and parameters' and suggested a guideline for that. It's currently available only for userspace branch.

Cheers,
Dongsu

Other related posts: