[pisa-src] Re: r894 - trunk/libpisa
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 02 Sep 2009 12:59:17 +0200
On Tue, Sep 01, 2009 at 06:46:09PM +0200, Diego Biurrun wrote:
> On Tue, Sep 01, 2009 at 06:38:29PM +0200, Thomas Jansen wrote:
> > On Tue, Sep 01, 2009 at 10:32:48AM +0200, Diego Biurrun wrote:
> >
> > > > --- trunk/libpisa/pisaconf.c Thu Aug 27 19:23:00 2009 (r893)
> > > > +++ trunk/libpisa/pisaconf.c Mon Aug 31 12:18:01 2009 (r894)
> > > > @@ -117,7 +108,7 @@
> > > >
> > > > /* bind the socket with the local address */
> > > > if ( bind(fd_peer, (struct sockaddr *)&sin, sizeof(sin)) < 0)
> > > > - die("pisa_tunnel_open_socket: socket-bind failed",4);
> > > > + die("pisa_conf_open_server_socket: socket-bind failed",4);
> > >
> > > stray hunk?
> >
> > That was a fix for a sloppy copy-paste. If you call die *and* specify the
> > function name explicity it should be updated when you copy-paste a function.
> > Or one could use __FUNCTION__.
> >
> > Now I'm probably getting scolded for not breaking that up into two commits
> > or
> > at least mentioning it in the commit log. ;)
>
> Exactly. IMNSHO failing to split it into two commits should be punished
> by a sever whipping. Failing to mention it in the commit message should
> be punished by summary execution.
Note that I grew up under the MPlayer/FFmpeg school of hard knocks where
- to this day - you actually do receive these punishments :)
> So please go ahead and at least fix the commit message.
Go ahead, issue that single svn command, pretty please.
Diego
Other related posts:
