[pisa-src] Re: r2512 - in trunk: Makefile.am tools/dhcp tools/dhcp/README tools/dhcp/mac2ip.c tools/dhcp/mac2ip.h
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Tue, 15 Nov 2011 18:22:30 +0100
On Tue, Apr 05, 2011 at 12:20:16AM +0200, Christoph Viethen wrote:
>
> Log:
> add directory for PiSA-specific DHCP code development (ensuring dist.
> tarball completeness); dir initially contains the original MAC2IP code
> fragments by Max Gelmroth, subject to review and possibly bugfixing
>
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ trunk/tools/dhcp/mac2ip.c Tue Apr 5 00:20:14 2011 (r2512)
> @@ -0,0 +1,276 @@
> +/**
> + * This Code calculates IPv4s based on Ethernet-addresses
> + *
> + * Author: Max Gelmroth
> + */
... and the license is?
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ trunk/tools/dhcp/mac2ip.h Tue Apr 5 00:20:14 2011 (r2512)
> @@ -0,0 +1,60 @@
> +
> +#ifndef __MAC2IP_H__
> +#define __MAC2IP_H__
illegal identifier
> +typedef struct mac2ip_ipv4_t{
> + uint8_t x[4];
> +} mac2ip_ipv4_t;
> +
> +typedef struct mac2ip_mac_t{
> + uint8_t x[6];
> +} mac2ip_mac_t;
> +
> +typedef struct ip_bounds {
> + mac2ip_ipv4_t bound[4];
> +
> +} ip_bounds;
> +
> +int mac_to_ip(const mac2ip_mac_t *, mac2ip_ipv4_t *);
> +
> +int read_ip_bounds(ip_bounds *);
> +
> +#endif /* __MAC2IP_H__
> */
All of this is only used in the corresponding .c file. As it thus is no
interface to external code it should all be declared in the .c file
directly. All those functions should then be made static.
Diego
--
This is the pisa developer mailing list. Please also subscribe to the main pisa
list at:
//www.freelists.org/list/pisa
Other related posts:
