[pisa-src] Re: r2414 - trunk/tools/testbed/scripts/build_deb
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Tue, 25 Jan 2011 16:28:47 +0100
On Mon, Jan 24, 2011 at 10:45:42AM +0100, Samuel Richter wrote:
>
> Log:
> fix indentation
That's what you claim, but ...
> --- trunk/tools/testbed/scripts/build_deb Thu Jan 20 15:20:13 2011
> (r2413)
> +++ trunk/tools/testbed/scripts/build_deb Mon Jan 24 10:45:42 2011
> (r2414)
> @@ -76,13 +76,15 @@
>
> - # create chroot environment if neccessary
> - [ -d $COW_PATH ] || cowbuilder --create --architecture $ARCH \
> - --distribution $DISTRIBUTION --basepath $COW_PATH \
> - --othermirror "deb http://archive.ubuntu.com/ubuntu maverick
> main restricted universe multiverse"
> + # create or update chroot environment
> + if [ -d $COW_PATH ]; then
> + cowbuilder --update --architecture $ARCH --basepath $COW_PATH
> + else
> + cowbuilder --create --architecture $ARCH \
> + --distribution $DISTRIBUTION --basepath $COW_PATH \
> + --othermirror "deb http://archive.ubuntu.com/ubuntu maverick
> main restricted universe multiverse"
> + fi
>
> - # update chroot
> - cowbuilder --update --architecture $ARCH --basepath $COW_PATH
... the diff disagrees, you are changing the logic, the --update command
was run unconditionally before.
Also, you now have a mix of 2 and 4 space indentation.
Diego
--
This is the pisa developer mailing list. Please also subscribe to the main pisa
list at:
//www.freelists.org/list/pisa
Other related posts:
