[pisa-src] Re: r1152 - in trunk/community-operator: Makefile.am co_client.c co_client.cfg co_common_packets.h co_server.c hipl.c hipl.h
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Thu, 15 Oct 2009 13:10:46 +0200
On Thu, Oct 15, 2009 at 11:19:04AM +0200, Thomas Jansen wrote:
> On Wed, Oct 14, 2009 at 05:22:24PM +0200, Jan Marten wrote:
>
> > -INCLUDES += -I@PISA_HIPL_SRCDIR@/libdht
> > +INCLUDES += -I@PISA_HIPL_SRCDIR@/opendht
>
> Diego, is this correct? I remember some bugfixes related to a change in the
> directory name not so long ago...
I don't remember off the top of my head, but I think one works with the
midauth branch of hipl and one with the midauth2 branch.
> > +if PISA_WITH_HIPL
> > +# TODO correct linking
> > +# pisa_split_cert function is needed in co_client.c
> > + co_client_LDADD += @PISA_HIPL_SRCDIR@/firewall/pisa_cert.o
> > +endif
>
> Not correct indeed, but I didn't have a nice solution for that problem when I
> talked to Jan yesterday. Still this needs to be resolved, before we can
> continue to create a better world (i.e. have a single makefile).
>
> Perhaps the C file could be added to the sources of the project directly? Not
> by copying, but by referencing the out of tree source file in
> @PISA_HIPL_SRCDIR@/firewall.
How large is the function? We could copy it as well...
> Some comments on style: I appreciate that you changed my quick-n-dirty
> CamelCaseNotation to the appropriate underscore_notation, but why did you
> replace tab indentation with spaces? It is inconsistent with virtually every
> other line of C code in the repository and uses four times as many characters
> to achieve the same as a tab would do. I know the rule in doc/HACKING states
> "Use
> 4 spaces as TAB in userspace and 8 spaces ad TAB in kernelspace!" and for me
> that translates to "set your editor to a tab width of 4 or 8". I admit though,
> that it is easy to misunderstand the way that the rule is written.
I understood it to mean "use 4 space indentation in userspace, tabs in
kernelspace".
Diego
Other related posts:
