[pisa-src] Re: IMPORTANT: Code review scheduled for week 2.11. - 6.11.
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Tue, 27 Oct 2009 12:48:38 +0100
On Fri, Oct 23, 2009 at 02:25:04PM +0200, Thomas Jansen wrote:
> On Thu, Oct 22, 2009 at 03:14:47PM +0200, René Hummen wrote:
>
> For all the text in the mail, it's a rather vague description of what's
> actually planned.
Some random comments..
> > Therefore and in order to get a better understanding of the codebase for
> > the new project members, I am scheduling a code review for the whole week
> > from 2.11. - 6.11.
>
> A whole week? Who do you consider "project members" for the code review?
> If that includes the average 10h/week HiWi, then 'a week' is quite a
> euphemism. Especially for the HiWis it's difficult to agree on a time when
> everyone has to be present.
Maybe we can schedule the meeting for Monday 10:00 or so and then people
work during the week.
> > Diego and Thomas have already been doing a great job at cleaning up the
> > code for the last 1 - 2 weeks, so maybe we might just find out that it is
> > in a perfect shape by now.
>
> True, we've been cleaning up tons of things that have been around for ages
> without anyone wondering why or how it really works. Still we both have some
> tasks left before we can call it "done" (or rather a reasonable starting point
> for further development).
Yes, there is a bunch of stuff left on my todo list. Every time I take
a closer look I notice more nonsense and the list gets longer and
longer...
> The current build system with autotools and recursive make is a known weakness
> and Diego has been on that task for quite a while.
Finishing this will still take a moment as I need to untangle and
understand a web of cruft where more than 50% is redundant or unneeded
or plain wrong.
> So I guess my main question is: What's the purpose of the code review and how
> exactly should it happen? As there are still three weeks left, perhaps some
> preparations should be made, like everyone making a list of things they want
> to discuss?
- coding style
- Subversion usage guidelines and/or best practices
Diego
Other related posts:
