[nvda-addons] Re: commit/windows7magnifier: mhameed: Mark three more ui.message() strings for translation.
- From: Mesar Hameed <mesar.hameed@xxxxxxxxx>
- To: nvda-addons@xxxxxxxxxxxxx
- Date: Tue, 14 May 2013 01:04:04 +0200
Hi Dominic,
Good work :)
nits:
* multiple messages marked for translation should be split over multiple
lines.
* Translator messages for some/all of the strings, i.e. give the
translator a warning that the naming/capitilization needs to be the same
as their found in windows, otherwise people will translate without
suspecting that the exact match is required for the code lookup to
function.
* __init__.py:692 label=_(boxArg[1])
I dont think _() can be used in that way, because gettext is run at
static time to produce the catalogue rather than dynamically when the
code is run, alternatively do we know that all boxArg[1] possible strings
have been marked for translation elsewhere?
open question: various time.sleep and their constants can be found in
various places, due to computer spec/current load might these be
invalidated? Can anything else be done instead of this?
Sorry I dont use windows at all, so dont have any useful ideas, but
might be worth asking mick/jamie on the dev list.
> - ("closeWithNVDA", _("&Close the magnifier when NVDA
> starts")),
> + ("closeWithNVDA", _("&Close the magnifier when NVDA is
> terminated")),
The message seemed a little wrong, if infact I missunderstood the
intension please correct.
Thanks,
Mesar
On Mon 13/05/13,22:36, commits-noreply@xxxxxxxxxxxxx wrote:
> 1 new commit in windows7magnifier:
>
> https://bitbucket.org/nvdaaddonteam/windows7magnifier/commits/998ce696303f/
> Changeset: 998ce696303f
> Branch: master
> User: mhameed
> Date: 2013-05-14 00:36:13
> Summary: Mark three more ui.message() strings for translation.
> Fix suspected copy/paste error, should magnifier be terminated when nvda is
> quit.
>
> Affected #: 1 file
>
> diff --git a/addon/globalPlugins/Windows7Magnifier/__init__.py
> b/addon/globalPlugins/Windows7Magnifier/__init__.py
> index 8230404..79a2596 100644
> --- a/addon/globalPlugins/Windows7Magnifier/__init__.py
> +++ b/addon/globalPlugins/Windows7Magnifier/__init__.py
> @@ -154,7 +154,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
> @param gesture: the gesture which caused this action
> """
> if self.isMagnifierRunning():
> - ui.message("Closing magnifier")
> + ui.message(_("Closing magnifier"))
> # Pause so the speech can complete uninterrupted
> time.sleep(1)
> self.closeMagnifier()
> @@ -549,7 +549,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
> followTextInsertion =
> Windows7MagnifierConfig.conf["magnifier"]["followTextInsertion"]
> )
>
> - ui.message("Settings applied")
> + ui.message(_("Settings applied"))
>
> # beep to indicate readiness
> for i in range(3):
> @@ -669,7 +669,7 @@ class MagnifierSettingsDialog(gui.SettingsDialog):
> boxArgs = [
> None,
> ("startWithNVDA", _("&Start the magnifier when NVDA
> starts")),
> - ("closeWithNVDA", _("&Close the magnifier when NVDA
> starts")),
> + ("closeWithNVDA", _("&Close the magnifier when NVDA is
> terminated")),
> ("hideMagnifierControls", _("&Hide the magnifier
> control window")),
> ("muteNVDA", _("Mute NVDA when the magnifier control
> window has focus (requires reload)")),
> None,
> @@ -734,7 +734,7 @@ class MagnifierSettingsDialog(gui.SettingsDialog):
> trackingSelected = True
> break
> if self.getMode() != "Lens" and not trackingSelected:
> - ui.message("You must select at least one 'Follow'
> option")
> + ui.message(_("You must select at least one 'Follow'
> option"))
> else:
> for name,box in self.checkBoxes.items():
> Windows7MagnifierConfig.conf["magnifier"][name]
> = box.IsChecked()
>
> Repository URL: https://bitbucket.org/nvdaaddonteam/windows7magnifier/
>
> --
>
> This is a commit notification from bitbucket.org. You are receiving
> this because you have the service enabled, addressing the recipient of
> this email.
> ----------------------------------------------------------------
>
> NVDA add-ons Central: A list for discussing NVDA add-ons
>
> To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
>
> To unsubscribe, send an email with the subject line of "unsubscribe" (without
> quotes) to nvda-addons-request@xxxxxxxxxxxxx.
>
> If you have questions for list moderators, please send a message to
> nvda-addons-moderators@xxxxxxxxxxxxx.
>
----------------------------------------------------------------
NVDA add-ons Central: A list for discussing NVDA add-ons
To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
To unsubscribe, send an email with the subject line of "unsubscribe" (without
quotes) to nvda-addons-request@xxxxxxxxxxxxx.
If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
Other related posts:
