Hi:
a) Basic review:good, but I think other could be removed to ease of review.
Thanks.
1. License and copyright: pass
Note: As license is not explicitly provided, pass applying GNU 2 as a
derived work of NVDA
2. Sequrity: Pass.
3. User experience: Pass (it doesn't mangle NVDA or system features).
b) Translatable strings:
* Look at script_announceResourceSummary. Some messages don't have
translator comment or it doesn't start with Translators:
c) Other notes:
* Terrabyte is used as a long name. Shouldn't be terabyte, with a single r?
* It seems to be many comments. For me comments in the function which
gets windows version are
b
El 05/07/2016 a las 4:44, Joseph Lee escribió:
Hi all,----------------------------------------------------------------
Opening up Resource Monitor 4.6 for review before going live later this
month:
* Basic review
* Translatable strings
Thanks.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-commits-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-commits-bounce@xxxxxxxxxxxxx] On Behalf Of
commits-noreply@xxxxxxxxxxxxx
Sent: Monday, July 4, 2016 7:43 PM
To: nvda-addons-commits@xxxxxxxxxxxxx
Subject: commit/resourceMonitor: josephsl: Finally, Windows Server 10 is
Server 2016.
1 new commit in resourceMonitor:
https://bitbucket.org/nvdaaddonteam/resourcemonitor/commits/a4926d3eac7c/
Changeset: a4926d3eac7c
Branch: master
User: josephsl
Date: 2016-07-05 02:42:47+00:00
Summary: Finally, Windows Server 10 is Server 2016.
Affected #: 1 file
diff --git a/addon/globalPlugins/resourceMonitor/__init__.py
b/addon/globalPlugins/resourceMonitor/__init__.py
index 3c8da6b..9a25802 100644
--- a/addon/globalPlugins/resourceMonitor/__init__.py
+++ b/addon/globalPlugins/resourceMonitor/__init__.py
@@ -158,7 +158,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
elif winMajor == 10: # Windows 10/Server 2016 (10.0).
if winMinor == 0:
# Remove this once WinTen is officially
released unless MS decides to update build numbers during automatic updates.
- winverName = "Windows 10" if server == 1
else "Windows Server 10"
+ winverName = "Windows 10" if server == 1
else "Windows Server 2016"
buildNum = sys.getwindowsversion().build
# Translators: Presented under 64-bit Windows.
if is64Bit: x64 = _("64-bit")
Repository URL: https://bitbucket.org/nvdaaddonteam/resourcemonitor/
--
This is a commit notification from bitbucket.org. You are receiving this
because you have the service enabled, addressing the recipient of this
email.
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
