[nvda-addons] commit/nvda: 10 new changesets

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: nvda-addons@xxxxxxxxxxxxx
  • Date: Tue, 28 May 2013 10:16:36 -0000

10 new commits in nvda:

https://bitbucket.org/nvdaaddonteam/nvda/commits/a971aa9d3e03/
Changeset:   a971aa9d3e03
Branch:      None
User:        mdcurran
Date:        2013-05-27 01:11:12
Summary:     Mention PowerPoint specific command  toggleSpeakerNotes in the 
user guide. And fix capitalization. Fixes #3137.

Affected #:  1 file

diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t
index e925f3d..30988eb 100644
--- a/user_docs/en/userGuide.t2t
+++ b/user_docs/en/userGuide.t2t
@@ -516,7 +516,13 @@ NVDA provides its own extra commands for some applications 
to make certain tasks
 | Set row headers | NVDA+shift+r | Pressing this once tells NVDA this is the 
column that contains row headers, which should be automatically announced when 
moving between rows after  this column. Pressing twice will clear the setting. 
| 
 %kc:endInclude
 
-++ foobar2000 ++
+++ Microsoft PowerPoint ++
+%kc:beginInclude
+|| Name | Key | Description |
+| Toggle speaker notes reading | control+shift+s | When in a running slide 
show, this command will toggle between the speaker notes for the slide and the 
content for the slide. This only affects what NVDA reads, not what is displayed 
on screen. | 
+%kc:endInclude
+
+++ Foobar2000 ++
 %kc:beginInclude
 || Name | Key | Description |
 | Report remaining time | control+shift+r | Reports the remaining time of the 
currently playing track, if any. |


https://bitbucket.org/nvdaaddonteam/nvda/commits/02ac2a55a4f8/
Changeset:   02ac2a55a4f8
Branch:      None
User:        mdcurran
Date:        2013-05-27 01:13:39
Summary:     Revert capitalization as foobar2000 is really with lower f

Affected #:  1 file

diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t
index 30988eb..d6f221c 100644
--- a/user_docs/en/userGuide.t2t
+++ b/user_docs/en/userGuide.t2t
@@ -522,7 +522,7 @@ NVDA provides its own extra commands for some applications 
to make certain tasks
 | Toggle speaker notes reading | control+shift+s | When in a running slide 
show, this command will toggle between the speaker notes for the slide and the 
content for the slide. This only affects what NVDA reads, not what is displayed 
on screen. | 
 %kc:endInclude
 
-++ Foobar2000 ++
+++ foobar2000 ++
 %kc:beginInclude
 || Name | Key | Description |
 | Report remaining time | control+shift+r | Reports the remaining time of the 
currently playing track, if any. |


https://bitbucket.org/nvdaaddonteam/nvda/commits/c7ba04d5e094/
Changeset:   c7ba04d5e094
Branch:      None
User:        mdcurran
Date:        2013-05-28 06:20:45
Summary:     NVDAHelper IME support: only call hasValidIMEContext for specific 
IME window messages, rather than for all window messages. Fixes #2909

This stops ImmLockIMC from being called for window messages such as wm_keydown 
which was causing some corruption of typed characters in certain situations 
such as when typing in NVDA's process with Korean or Japanese when it was the 
default IME.

Affected #:  2 files

diff --git a/nvdaHelper/remote/ime.cpp b/nvdaHelper/remote/ime.cpp
index 8a0ad4c..e76b58b 100644
--- a/nvdaHelper/remote/ime.cpp
+++ b/nvdaHelper/remote/ime.cpp
@@ -410,10 +410,9 @@ bool hasValidIMEContext(HWND hwnd) {
 }
 
 static LRESULT handleIMEWindowMessage(HWND hwnd, UINT message, WPARAM wParam, 
LPARAM lParam) {
-       // Ignore messages with invalid HIMC
-       if(!hasValidIMEContext(hwnd)) return 0; 
        switch (message) {
                case WM_IME_NOTIFY:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        switch (wParam) {
                                case IMN_SETOPENSTATUS:
                                        handleOpenStatus(hwnd);
@@ -440,6 +439,7 @@ static LRESULT handleIMEWindowMessage(HWND hwnd, UINT 
message, WPARAM wParam, LP
                        break;
 
                case WM_IME_COMPOSITION:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        curIMEWindow=hwnd;
                        if(!isTSFThread(true)) {\
                                if(lParam&GCS_COMPSTR||lParam&GCS_CURSORPOS) {
@@ -449,6 +449,7 @@ static LRESULT handleIMEWindowMessage(HWND hwnd, UINT 
message, WPARAM wParam, LP
                        break;
 
                case WM_IME_ENDCOMPOSITION:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        if(curIMEWindow==hwnd) {
                                if(handleEndComposition(hwnd, wParam, lParam)) {
                                        //Disable further typed character 
notifications produced by TSF
@@ -460,6 +461,7 @@ static LRESULT handleIMEWindowMessage(HWND hwnd, UINT 
message, WPARAM wParam, LP
 
                case WM_ACTIVATE:
                case WM_SETFOCUS:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        handleIMEConversionModeUpdate(hwnd,false);
                        if(!isTSFThread(true)) {
                                if (hwnd != GetFocus())  break;

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index 4acafae..2153022 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -82,6 +82,7 @@ Please see the [Commands Quick Reference keyCommands.html] 
document for the new
 - NVDA no longer fails to copy user settings for use on logon and other secure 
screens when the user's profile path contains non-ASCII characters. (#3092)
 - NVDA no longer freezes when using Asian character input in some .NET 
applications. (#3005)
 - it is now possible to use browse mode for pages in Internet Explorer 10 when 
in standards mode; e.g. www.gmail.com login page. (#3151)
+- Correct characters are produced when typing in NVDA's own user interface 
while using a Korean or Japanese input method while it is the default method. 
(#2909)
 
 
 == Changes for Developers ==


https://bitbucket.org/nvdaaddonteam/nvda/commits/292a3444158b/
Changeset:   292a3444158b
Branch:      None
User:        mdcurran
Date:        2013-05-28 07:01:48
Summary:     Merge branch 'heads/release-2013.1'

Affected #:  2 files

diff --git a/nvdaHelper/remote/ime.cpp b/nvdaHelper/remote/ime.cpp
index 8a0ad4c..e76b58b 100644
--- a/nvdaHelper/remote/ime.cpp
+++ b/nvdaHelper/remote/ime.cpp
@@ -410,10 +410,9 @@ bool hasValidIMEContext(HWND hwnd) {
 }
 
 static LRESULT handleIMEWindowMessage(HWND hwnd, UINT message, WPARAM wParam, 
LPARAM lParam) {
-       // Ignore messages with invalid HIMC
-       if(!hasValidIMEContext(hwnd)) return 0; 
        switch (message) {
                case WM_IME_NOTIFY:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        switch (wParam) {
                                case IMN_SETOPENSTATUS:
                                        handleOpenStatus(hwnd);
@@ -440,6 +439,7 @@ static LRESULT handleIMEWindowMessage(HWND hwnd, UINT 
message, WPARAM wParam, LP
                        break;
 
                case WM_IME_COMPOSITION:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        curIMEWindow=hwnd;
                        if(!isTSFThread(true)) {\
                                if(lParam&GCS_COMPSTR||lParam&GCS_CURSORPOS) {
@@ -449,6 +449,7 @@ static LRESULT handleIMEWindowMessage(HWND hwnd, UINT 
message, WPARAM wParam, LP
                        break;
 
                case WM_IME_ENDCOMPOSITION:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        if(curIMEWindow==hwnd) {
                                if(handleEndComposition(hwnd, wParam, lParam)) {
                                        //Disable further typed character 
notifications produced by TSF
@@ -460,6 +461,7 @@ static LRESULT handleIMEWindowMessage(HWND hwnd, UINT 
message, WPARAM wParam, LP
 
                case WM_ACTIVATE:
                case WM_SETFOCUS:
+                       if(!hasValidIMEContext(hwnd)) return 0;
                        handleIMEConversionModeUpdate(hwnd,false);
                        if(!isTSFThread(true)) {
                                if (hwnd != GetFocus())  break;

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index ae9c1cc..91ba572 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -108,6 +108,7 @@ Please see the [Commands Quick Reference keyCommands.html] 
document for the new
 - NVDA no longer fails to copy user settings for use on logon and other secure 
screens when the user's profile path contains non-ASCII characters. (#3092)
 - NVDA no longer freezes when using Asian character input in some .NET 
applications. (#3005)
 - it is now possible to use browse mode for pages in Internet Explorer 10 when 
in standards mode; e.g. www.gmail.com login page. (#3151)
+- Correct characters are produced when typing in NVDA's own user interface 
while using a Korean or Japanese input method while it is the default method. 
(#2909)
 
 
 == Changes for Developers ==


https://bitbucket.org/nvdaaddonteam/nvda/commits/fd0e21e0316b/
Changeset:   fd0e21e0316b
Branch:      None
User:        jteh
Date:        2013-05-28 07:16:49
Summary:     skype: Fix errors when opening Open and Save dialogs and possibly 
in other places.

event_NVDAObject_init wasn't checking for IAccessible before checking 
event_objectID, which broke any UIA objects.
Fixes #3249.

Affected #:  1 file

diff --git a/source/appModules/skype.py b/source/appModules/skype.py
index 8f1d3c7..75ac77c 100644
--- a/source/appModules/skype.py
+++ b/source/appModules/skype.py
@@ -107,7 +107,7 @@ class AppModule(appModuleHandler.AppModule):
                self.chatOutputList = None
 
        def event_NVDAObject_init(self,obj):
-               if obj.event_objectID is None and controlTypes.STATE_FOCUSED in 
obj.states and obj.role not in 
(controlTypes.ROLE_POPUPMENU,controlTypes.ROLE_MENUITEM,controlTypes.ROLE_MENUBAR):
+               if isinstance(obj, NVDAObjects.IAccessible.IAccessible) and 
obj.event_objectID is None and controlTypes.STATE_FOCUSED in obj.states and 
obj.role not in 
(controlTypes.ROLE_POPUPMENU,controlTypes.ROLE_MENUITEM,controlTypes.ROLE_MENUBAR):
                        # The window handle reported by Skype accessibles is 
sometimes incorrect.
                        # This object is focused, so we can override with the 
focus window.
                        
obj.windowHandle=winUser.getGUIThreadInfo(None).hwndFocus


https://bitbucket.org/nvdaaddonteam/nvda/commits/4db91e501f79/
Changeset:   4db91e501f79
Branch:      None
User:        mdcurran
Date:        2013-05-28 07:22:33
Summary:     Move last bug fix in changes file up to 2013.1.1

Affected #:  1 file

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index 2153022..3ccdf7c 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -3,6 +3,12 @@
 
 %!includeconf: ../changes.t2tconf
 
+= 2013.1.1 =
+
+== Bug Fixes ==
+- Correct characters are produced when typing in NVDA's own user interface 
while using a Korean or Japanese input method while it is the default method. 
(#2909)
+
+
 = 2013.1 =
 Highlights of this release include a more intuitive and consistent laptop 
keyboard layout; basic support for Microsoft PowerPoint; support for long 
descriptions in web browsers; and support for input of computer braille for 
braille displays which have a braille keyboard.
 
@@ -82,7 +88,6 @@ Please see the [Commands Quick Reference keyCommands.html] 
document for the new
 - NVDA no longer fails to copy user settings for use on logon and other secure 
screens when the user's profile path contains non-ASCII characters. (#3092)
 - NVDA no longer freezes when using Asian character input in some .NET 
applications. (#3005)
 - it is now possible to use browse mode for pages in Internet Explorer 10 when 
in standards mode; e.g. www.gmail.com login page. (#3151)
-- Correct characters are produced when typing in NVDA's own user interface 
while using a Korean or Japanese input method while it is the default method. 
(#2909)
 
 
 == Changes for Developers ==


https://bitbucket.org/nvdaaddonteam/nvda/commits/b47bd9a85751/
Changeset:   b47bd9a85751
Branch:      None
User:        mdcurran
Date:        2013-05-28 07:25:33
Summary:     Merged release-2013.1

Affected #:  1 file

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index 91ba572..a42ee75 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -29,6 +29,12 @@
 - windowUtils.findDescendantWindow has been added to search for a descendant 
window (HWND) matching the specified visibility, control ID and/or class name.
 
 
+= 2013.1.1 =
+
+== Bug Fixes ==
+- Correct characters are produced when typing in NVDA's own user interface 
while using a Korean or Japanese input method while it is the default method. 
(#2909)
+
+
 = 2013.1 =
 Highlights of this release include a more intuitive and consistent laptop 
keyboard layout; basic support for Microsoft PowerPoint; support for long 
descriptions in web browsers; and support for input of computer braille for 
braille displays which have a braille keyboard.
 
@@ -108,7 +114,6 @@ Please see the [Commands Quick Reference keyCommands.html] 
document for the new
 - NVDA no longer fails to copy user settings for use on logon and other secure 
screens when the user's profile path contains non-ASCII characters. (#3092)
 - NVDA no longer freezes when using Asian character input in some .NET 
applications. (#3005)
 - it is now possible to use browse mode for pages in Internet Explorer 10 when 
in standards mode; e.g. www.gmail.com login page. (#3151)
-- Correct characters are produced when typing in NVDA's own user interface 
while using a Korean or Japanese input method while it is the default method. 
(#2909)
 
 
 == Changes for Developers ==


https://bitbucket.org/nvdaaddonteam/nvda/commits/3fba11be6d6d/
Changeset:   3fba11be6d6d
Branch:      None
User:        mdcurran
Date:        2013-05-28 07:26:07
Summary:     Merge branch 'master' of ssh://pebi.nvaccess.org/srv/git/nvda

Affected #:  1 file

diff --git a/source/appModules/skype.py b/source/appModules/skype.py
index 8f1d3c7..75ac77c 100644
--- a/source/appModules/skype.py
+++ b/source/appModules/skype.py
@@ -107,7 +107,7 @@ class AppModule(appModuleHandler.AppModule):
                self.chatOutputList = None
 
        def event_NVDAObject_init(self,obj):
-               if obj.event_objectID is None and controlTypes.STATE_FOCUSED in 
obj.states and obj.role not in 
(controlTypes.ROLE_POPUPMENU,controlTypes.ROLE_MENUITEM,controlTypes.ROLE_MENUBAR):
+               if isinstance(obj, NVDAObjects.IAccessible.IAccessible) and 
obj.event_objectID is None and controlTypes.STATE_FOCUSED in obj.states and 
obj.role not in 
(controlTypes.ROLE_POPUPMENU,controlTypes.ROLE_MENUITEM,controlTypes.ROLE_MENUBAR):
                        # The window handle reported by Skype accessibles is 
sometimes incorrect.
                        # This object is focused, so we can override with the 
focus window.
                        
obj.windowHandle=winUser.getGUIThreadInfo(None).hwndFocus


https://bitbucket.org/nvdaaddonteam/nvda/commits/d30a09bf0341/
Changeset:   d30a09bf0341
Branch:      None
User:        jteh
Date:        2013-05-28 07:45:26
Summary:     You can now disable displaying of NVDA messages on a braille 
display by setting the message timeout to 0 in the Braille Settings dialog.

Patch from Ali-Riza Ciftcioglu with documentation by me.
Fixes #2482.

Affected #:  4 files

diff --git a/source/braille.py b/source/braille.py
index e19521c..8a301c6 100644
--- a/source/braille.py
+++ b/source/braille.py
@@ -1330,7 +1330,7 @@ class BrailleHandler(baseObject.AutoPropertyObject):
                If a key is pressed the message will be dismissed by the next 
text being written to the display
                @postcondition: The message is displayed.
                """
-               if not self.enabled:
+               if not self.enabled or config.conf["braille"]["messageTimeout"] 
== 0:
                        return
                if self.buffer is self.messageBuffer:
                        self.buffer.clear()

diff --git a/source/gui/settingsDialogs.py b/source/gui/settingsDialogs.py
index 1380f0a..a177d58 100644
--- a/source/gui/settingsDialogs.py
+++ b/source/gui/settingsDialogs.py
@@ -1338,7 +1338,7 @@ class BrailleSettingsDialog(SettingsDialog):
                        val = int(self.messageTimeoutEdit.GetValue())
                except (ValueError, TypeError):
                        val = None
-               if 1 <= val <= 20:
+               if 0 <= val <= 20:
                        config.conf["braille"]["messageTimeout"] = val
                braille.handler.tether = 
self.tetherValues[self.tetherList.GetSelection()][0]
                config.conf["braille"]["readByParagraph"] = 
self.readByParagraphCheckBox.Value

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index a42ee75..ede1438 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -10,6 +10,7 @@
 - New eSpeak voice variant: Iven3.
 - In Skype, new chat messages are reported automatically while the 
conversation is focused. (#2298)
 - Support for Tween, including reporting of tab names and less verbosity when 
reading tweets.
+- You can now disable displaying of NVDA messages on a braille display by 
setting the message timeout to 0 in the Braille Settings dialog. (#2482)
 
 
 == Changes ==

diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t
index d6f221c..8e4262e 100644
--- a/user_docs/en/userGuide.t2t
+++ b/user_docs/en/userGuide.t2t
@@ -736,7 +736,8 @@ This option allows the word that is under the cursor to be 
displayed in non-cont
 This option is a numerical field that allows you to change the blink rate of 
the cursor in milliseconds.
 
 ==== Message Timeout (sec) ====
-This option is a numerical field that controls how long system messages are 
displayed on the braille display.
+This option is a numerical field that controls how long NVDA messages are 
displayed on the braille display.
+Specifying 0 disables displaying of these messages completely.
 
 %kc:setting
 ==== Braille Tethered to ====[BrailleTether]


https://bitbucket.org/nvdaaddonteam/nvda/commits/00984d5d4efc/
Changeset:   00984d5d4efc
Branch:      master
User:        jteh
Date:        2013-05-28 09:37:26
Summary:     In the Add-ons Manager, there is now a Get Add-ons button to open 
the NVDA Add-ons web site where you can browse and download availible add-ons.

Patch by Beqa Gozalishvili with minor changes by me.
Fixes #3209.

Affected #:  3 files

diff --git a/source/gui/addonGui.py b/source/gui/addonGui.py
index 42d65b6..920ca8c 100644
--- a/source/gui/addonGui.py
+++ b/source/gui/addonGui.py
@@ -2,15 +2,16 @@
 #A part of NonVisual Desktop Access (NVDA)
 #This file is covered by the GNU General Public License.
 #See the file COPYING for more details.
-#Copyright (C) 2012 NV Access Limited
+#Copyright (C) 2012-2013 NV Access Limited, Beqa Gozalishvili
 
+import os
 import wx
 import core
+import languageHandler
 import gui
 from logHandler import log
 import addonHandler
 
-
 class AddonsDialog(wx.Dialog):
        _instance = None
        def __new__(cls, *args, **kwargs):
@@ -48,6 +49,9 @@ class AddonsDialog(wx.Dialog):
                self.removeButton.Disable()
                self.removeButton.Bind(wx.EVT_BUTTON,self.OnRemoveClick)
                entryButtonsSizer.Add(self.removeButton)
+               self.getAddonsButton=wx.Button(self,label=_("&Get add-ons..."))
+               self.getAddonsButton.Bind(wx.EVT_BUTTON,self.OnGetAddonsClick)
+               entryButtonsSizer.Add(self.getAddonsButton)
                settingsSizer.Add(entryButtonsSizer)
                
mainSizer.Add(settingsSizer,border=20,flag=wx.LEFT|wx.RIGHT|wx.TOP)
                # Translators: The label of a button to close the Addons dialog.
@@ -205,6 +209,10 @@ Description: {description}
                title=_("Add-on Information")
                gui.messageBox(message, title, wx.OK)
 
+       def OnGetAddonsClick(self,evt):
+               ADDONS_URL = "http://addons.nvda-project.org/index.{lang}.html";
+               
os.startfile(ADDONS_URL.format(lang=languageHandler.getLanguage()))
+
        def __del__(self):
                AddonsDialog._instance = None
 

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index ede1438..419352d 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -11,6 +11,7 @@
 - In Skype, new chat messages are reported automatically while the 
conversation is focused. (#2298)
 - Support for Tween, including reporting of tab names and less verbosity when 
reading tweets.
 - You can now disable displaying of NVDA messages on a braille display by 
setting the message timeout to 0 in the Braille Settings dialog. (#2482)
+- In the Add-ons Manager, there is now a Get Add-ons button to open the NVDA 
Add-ons web site where you can browse and download availible add-ons. (#3209)
 
 
 == Changes ==

diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t
index 8e4262e..9e436c7 100644
--- a/user_docs/en/userGuide.t2t
+++ b/user_docs/en/userGuide.t2t
@@ -1089,9 +1089,16 @@ These packages are provided by the community and contain 
custom code that may ad
 The Add-ons Manager contains a list that displays all the add-ons currently 
installed in your NVDA user configuration. 
 A package name, version and author are shown for each add-on, though further 
information such as a description and URL can be viewed by selecting the add-on 
and pressing the About add-on button.
 
-To install an Add-on, press the Install button.
+To browse and download availible add-ons online, press the Get add-ons button.
+This button opens the [NVDA Add-ons page http://addons.nvda-project.org/].
+If NVDA is installed on your system, you can open the add-on directly from the 
browser to begin the installation process as described below.
+Otherwise, save the add-on package and follow the instructions below.
+
+To install an Add-on you previously obtained, press the Install button.
 This will allow you to browse for an add-on package (.nvda-addon file) 
somewhere on your computer or on a network.
-Once you press Open, NVDA will ask if you really wish to install the add-on.
+Once you press Open, the installation process will begin.
+
+When an add-on is being installed, NVDA will first ask you to confirm that you 
really wish to install the add-on.
 As the functionality of add-ons is unrestricted inside NVDA, which in theory 
could include accessing your personal data or even the entire system if NVDA is 
an installed copy, it is very important to only install add-ons from sources 
you trust.
 Once the add-on is installed, NVDA must be restarted for the add-on to start 
running. 
 Until you do, a status of "install" will show for that add-on in the list.

Repository URL: https://bitbucket.org/nvdaaddonteam/nvda/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
----------------------------------------------------------------

NVDA add-ons Central: A list for discussing NVDA add-ons

To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.

To unsubscribe, send an email with the subject line of "unsubscribe" (without 
quotes) to nvda-addons-request@xxxxxxxxxxxxx.

If you have questions for list moderators, please send a message to 
nvda-addons-moderators@xxxxxxxxxxxxx.

Community addons can be found here: http://addons.nvda-project.org

Other related posts:

  • » [nvda-addons] commit/nvda: 10 new changesets - commits-noreply