Hi, I haven't reviewed the code, but according with your revision, I agree with you. Furthermore, NVDA+shift+c could produce conflicts with the same command in the core. You don't mention script category, and perhaps it's not added.
Thanks. El 26/09/2014 23:51, Joseph Lee escribió:
Hi all, As someone suggested, here's my code review comments for Word add-on: * Script bindings: NVDA+Shift+R/C are now incorporated into NVDA core to set or remove table column and row headers. * Reporting revisions and comments: these have been implemented in NVDA core, so no need for them anymore unless there are users who uses NVDA 2014.2 or earlier. * Script docs: most of them give good overview of what the scripts do. However, scripts for reporting info on table cells and document information uses older style of doc string, which might be hard for some languages. * Script arguments: I never seen a script that takes arguments other than self and gesture - is it allowed? A possible suggestion would be to let the scripts call the actual methods who'll report the needed information. * Script names: I think some of the names of the scripts doesn't make sense when viewed by a code reviewer. For instance, the script to report table cell information and coordinates is named "report details", which may not explain what the script does. As for proposal for removing the add-on for now, my reasoning is that since the needed functionality has been added to NVDA core, there's no need for duplicate set of controls for Word, particularly for reporting revisions and comments. However, if there are users who absolutely need a command to report certain information about a document, then I propose deleting the features that are already in nVDA core and leave others behind, add t2694 support and try releasing the add-on after removing duplicate messages. Thanks. Cheers, Joseph
---------------------------------------------------------------- NVDA add-ons Central: A list for discussing NVDA add-ons To post a message, send an email to nvda-addons@xxxxxxxxxxxxx. To unsubscribe, send an email with the subject line of "unsubscribe" (without quotes) to nvda-addons-request@xxxxxxxxxxxxx. If you have questions for list moderators, please send a message to nvda-addons-moderators@xxxxxxxxxxxxx. Community addons can be found here: http://addons.nvda-project.org
