Hi,
I would say at least Alt+NvDA+O (opening tdf file path), as it allows people to
navigate other locations if they choose, as well as the add-on menu.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Hrvoje Katic
Sent: Monday, July 18, 2016 1:10 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Tone Master addon now on github
Hello and thanks for review.
I'll release 1.1 with fixes for all mentioned in review. Regarding security, do
you suggest me to disable addon's work on secure screens completely?
"Joseph Lee" <joseph.lee22590@xxxxxxxxx> wrote:
Hi,
Basic review:
* License: pass.
* Security: Pass (although it might be best to let the add-on detect it's
running in secure mode)
* User experience: pass (multi-threading issue though)
Comments:
* Loaded == None versus Lloaded is None versus not loaded: it's up to you.
Usually "loaded is None" might be a bit more clear.
* Parsing error: ui.message sounds nice, but it might be helpful to let the
user know about this via a pop-up.
* Multi-threading: if you press Alt+NvDA+T multiple times, you'll find that the
same tone plays multiple times. One way that might help is check if playback
var is set and react accordginly.
* Translator comments ofr docstrings please.
* Apart from minor spelling issues, readme is fine.
I recommend a green light once multi-threading issue is resolved. Thanks (and
this add-on has a huge potential). Will make it available for user testing on
the add-ons website.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Hrvoje Katic
Sent: Sunday, July 17, 2016 1:22 PM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Tone Master addon now on github
Hello,
The first release of the addon can be downloaded permanently from here:
https://github.com/nvdaaddons/toneMaster/releases/download/v1.0/toneMaster-1.0.nvda-addon
The source code repository can be found here:
https://github.com/nvdaaddons/toneMaster
Since I've declared the addon as stable, it can be reviewed. I'm not planning
to add any more features for V1.0. Eventual fixes and minor improvements will
go into 1.1 release.
LP,
Hrvoje
Web: www.hrvojekatic.com
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send a ;
message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send a ;
message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send a ;
message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
