## Place markers:
License: Pass.
Code: Pass
Readme: Pass
Overall: Green light, go ahead.
Minor code readability thing I found:
self.actionsList=wx.Choice(self,actionsListID, name=_("Select an action
to perform:"), choices=[name for name in actions])
could be:
self.actionsList=wx.Choice(self,actionsListID, name=_("Select an action
to perform:"), choices=actions)
Good work.
On 8/8/2016 1:26 PM, Noelia wrote:
Hi, here are the repos. I don't know what needs to be reviewed exactly in anual reviews.
I think you should review just the last commit for each repo, which contains copyright and licensing information, previously not added:
- placeMarkers:
https://github.com/nvdaaddons/placeMarkers
-eMule:
https://github.com/nvdaaddons/eMule
- readFeeds:
https://github.com/nvdaaddons/readFeeds
- emoticons:
https://github.com/nvdaaddons/emoticons
- clipContentsDesigner:
https://github.com/nvdaaddons/clipContentsDesigner
Thanks.
El 08/08/2016 a las 21:20, derek riemer escribió:
Hi Noleia:----------------------------------------------------------------
can you send links to the repositories, and if possible links to the
diff's and I'll review them. Alternatively, can you send the commit
number that I need to start my review with?
On 8/8/2016 12:37 PM, Noelia wrote:
Hi, as anual basic review is required in processes, I repeat this
request for these add-ons:
- clipContentsDesigner.
- emoticons.
- eMule.
- placeMarkers.
readFeeds.
What should be done if none is interested in reviewing add-ons posted
in the website, and anual review is required?
For now, I'm not updating them, though translation updates can be available.
I think this can happen with other add-ons too.
Cheers.
2016-07-29 18:40 GMT+02:00, Joseph Lee <joseph.lee22590@xxxxxxxxx>:
Hi,----------------------------------------------------------------
A sincere request: in order to let folks get acquainted with reviewing code
from others and to get into process (and also because of presentations I'll
be conducting this weekend and on Monday), I'd like to request someone
(preferably a person who is new to reviewing add-ons) take a look at these
add-ons. Thanks.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Noelia
Sent: Friday, July 29, 2016 9:37 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Requesting anual basic review for some add-ons
Hi, I have added license and copyright information, and request anual
required basic review, for these add-ons contributed by me:
- clipContentsDesigner.
- emoticons (main author: Chris).
- eMule.
- placeMarkers.
- readFeeds.
If this is OK, I will release them on August 1.
Later we can check Day of the week (main author Abdel), and TeamViewer,
which needs a removal of the control+tab script for cleanup, since it's not
used in recent versions of TeamViewer.
All this repos are imported to NVDA add-ons Github account, where I will
upload binaries for releases.
Thanks.
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send
a message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
--
------------------------------------------------------------------------
Derek Riemer
* Department of computer science, third year undergraduate student.
* Proud user of the NVDA screen reader.
* Open source enthusiast.
* Member of Bridge Cu
* Avid skiier.
Websites:
Honors portfolio <http://derekriemer.com>
Awesome little hand built weather app!
<http://django.derekriemer.com/weather/>
email me at derek.riemer@xxxxxxxxxxxx <mailto:derek.riemer@xxxxxxxxxxxx>
Phone: (303) 906-2194
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe: //www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
