I like it.
On 7/20/2016 12:33 PM, Joseph Lee wrote:
Hi,
Code review results:
·Licensing: pass
·Security: pass.
·User experience: pass with caution for specific audiences.
Comments:
·Thanks for addressing security concerns.
·Toasts: toast objects has been reorganized in latest next builds, so some of you may encounter an attribute error. Please see the following NVDA Core ticket for details:
https://github.com/nvaccess/nvda/issues/6096
·An interesting way of putting config.conf.spec (Derek and Noelia, any thoughts?).
Additional comments from others are appreciated. In the meantime, 5.1 beta will be going up to the add-ons site under dev section so users can give feedback.
Cheers,
Joseph
*From:*nvda-addons-bounce@xxxxxxxxxxxxx [mailto:nvda-addons-bounce@xxxxxxxxxxxxx] *On Behalf Of *Musharraf Omer
*Sent:* Wednesday, July 20, 2016 11:12 AM
*To:* nvda-addons@xxxxxxxxxxxxx
*Subject:* [nvda-addons] New Version: Audio Themes v5.1-beta
Hi all,
I've released version 5.1-beta of the Audio Themes add-on.
Download this beta from:
https://github.com/mush42/Audio-Themes-NVDA-Add-on/releases/download/5.1-beta/AudioThemes3D-5.1-beta.nvda-addon
Changes from 5.0-beta are as follows:
- Major security and performance enhancements
- Added support for ogg audio format.
- The add-on is now aware of if NVDA is running in a secure mode and changes its options accordingly.
- All the dialogs are now correctly centred in the screen.
- The themes options (such as: Play in 3D mode and use synth volume) will no longer be enabled if the Disable audio themes option is activated.
- The add-on uses config.conf as its configuration facility
- The add-on was updated to the upstream add-on template
- In the audio themes manager, themes now show whether they are active or not
- Minor bug fixes.
A Note on Versioning:
This new version is ought to be 5.0-beta2, but due to the introduction of Ogg format support I decided to jump directly to 5.1 and leave 5.0 in beta for ever.
I kindly ask code reviewers and beta testers to review and test this beta, because if no critical bugs were found this should be identical to the 5.1 stable release.
The 5.x versions of the audio themes add-on might be the last line of versions, as it may be integrated into the unspoken add-on if a planned pull request is accepted.
Kind Regards,
Musharraf Omer
