Hi,
This is using an old version of the addontemplate in that case (Please
update the addon tempate to the one found in
bitbucket.com/nvdaaddonteam/addontemplate).
On 7/14/2016 11:07 AM, Joseph Lee wrote:
Hi,
Basic code review results:
·License and copyright: pass (making sure we don’t run into issues with sounds and licenses).
·Security: pass, although may wish to allow the add-on to detect it’s running in secure screens (depends).
·User experience: pass (installed fine after modifying sconstruct, see below comment).
Comments:
·For name of the default theme, I think it would be good if it was left blank.
·Configuration: I think it’d be handy to use config.conf facility (perhaps for 6.0).
·Themes list: I think it would be helpful to let users know the selected one is the active theme (similar to how profiles list works).
·Building the add-on: sconstruct says it imports configobj but it isn’t used anywhere. This means people building the add-on should comment out “import configobj” line.
·Hope this add-on can take audio ducking into account.
·Additional comments are welcome (especially from speech synth and audio experts).
I must say this is one of the most reader-friendly add-ons I came across – helpful source code comments, easy to follow source code and so on. I recommend a green light for this add-on once sconstruct is fixed.
Cheers,
Joseph
*From:*nvda-addons-bounce@xxxxxxxxxxxxx [mailto:nvda-addons-bounce@xxxxxxxxxxxxx] *On Behalf Of *Musharraf Omer
*Sent:* Thursday, July 14, 2016 9:27 AM
*To:* nvda-addons@xxxxxxxxxxxxx
*Subject:* [nvda-addons] New Add-on (Audio Themes Version 5.0-beta)
Hello All,
I just published a new version of the Audio Themes add-on. The
repo is in github at:
https://github.com/mush42/Audio-Themes-NVDA-Add-on
The highlights of this release are:
- More organized, clean, and idiomatic code.
- The add-on was rewritten from the scratch to enhance its
performance, and generally to make things more easier.
- Added several new options in the Themes Manager dialogue including:
- The ability to run the add-on in 3D mode or Mono Mode.
- The ability to make NVDA ignore object role when announcing focus
- The ability to control the volume of the add-on, either by
setting the volume directly, or set it to follow the synthesizer
volume.
- Audio themes now shows information about their authors, and
authors can write a brief summary to describe their audio themes.
Those information will be shown in the themes manager dialogue.
- Easier way to edit the current audio theme.
- Fewer steps and streamlined process to create a new audio theme.
- The add-on can be considered a wrapper over the Unspoken
add-on which is being developed by Austin Hicks and Bryan Smart.
The majority of my development went into the dialogues and
audioThemeHandler modules.
For developer information see the file 'readme-developers.md' in
the repo.
So I kindly ask code reviewers and beta testers to review the code
and test the add-on, to be ready for possible inclusion into the
community add-ons site.
Kind Regards,
Musharraf Omer
