Hi Derek,
This good link is:
http://www.livetim.tim.com.br/emotisounds/downloads/emotisounds-2.4.nvda-addon
Sources:
https://bitbucket.org/nvdaaddonteam/emotisounds
Cheers since France.
Rémy
Le 28/06/2016 à 05:42, derek riemer a écrit :
Review:
Url: "addon_url" : "http://www.livetim.tim.com.br/emotisounds/downloads/emotisounds-2.0.nvda-addon";,
If possible provide a link to the webpage describing the add-on, rather than the download link.
pythonSources = [os.path.join("addon", "globalPlugins", "emotisounds", "*.py"),os.path.join("addon", "globalPlugins", "emotisounds", "waves", "*.wav")]
Hint: adding wav files to your buildVars is might cause trouble for you in that it'll not only copy them, but the translation system will try to find strings in the .wav files. I would recommend modifying the sconstruct.
Licensing:
Add the note about sounds being creative commons to the copying file please.
# -*- coding: UTF-8 -*-
Only put this on files that have utf-8 characters in them (if its a non-english locale for example). Reason: it will break the translation tools and your add-on won't do what you expect.
License for python files: Pass!
#This file uses part of the NVDA speech module, specificaly the speak method (Copyright (C) 2006-2014 NV Access Limited, Peter Vágner, Aleksey Sadovoy)
Slight spelling correction to make things clear:
#This file uses part of the NVDA speech module, specifically the speak method (Copyright (C) 2006-2014 NV Access Limited, Peter Vágner, Aleksey Sadovoy)
user experience: cannot proceed, vast improvement required.
your add-on needs work before we can pass it from our basic review. Your add-on breaks NVDA's speech functionality in detrimental ways. For example, speech becomes extremely sluggish, and NVDA fails to speak things like the roles of objects. Also, the documentation doesn't mention how to use the add-on. It should mention how it should be used. This add-on has potential, but the bugs that exist make it impossible to use the emodisounds functionality. We strongly recommend you use NVDA with this add-on enabled and disabled while doing work, so that you can gauge the severity of some of these bugs, and understand what's breaking. Also, if you are stuck with how to fix them, feel free to ask us, as there are several talented scripters who could provide you with recommendations on how to fix these bugs. Also, we would recommend you ask for a in depth review, because we think it would help you in finding and fixing potential bugs in your add-on, and learn about best practices for your code.
Thanks for your interest in submitting an add-on. Please let us know when you are ready to release a version, and we will run another review, help you initiate a development version and get it listed on the site. BTW, besides the wave files, your add-on should hook into the translation system easily.
On 6/27/2016 3:41 PM, Iguatemi Garin wrote:
Hi, Derek!
Sure, here is the link for the repo: https://bitbucket.org/nvdaaddonteam/emotisounds
For now, the "basic" review is enough, thanks.
Currently, there are just two sentences that would need translation, which are the add-on state message (on or off). I'm not sure what are the needed steps to translate it, though.
Bests
<http://hadrons.io>
On Sun, Jun 19, 2016 at 12:52 PM, Derek Riemer <deri4989@xxxxxxxxxxxx <mailto:deri4989@xxxxxxxxxxxx>> wrote:
The first thing we will need is a link to your repository.
Is well, we have a new review process in which we only check to
make sure you are not infringing other peoples copyright and to
make sure there is no dangerous code in your repository. If you
want and more in-depth review (such as checking your code style
and giving you suggestions on things that you should do to make
your ad on better in such) please also let us know
Also we are assuming that you want your ad on translated by
default. If you have your own translation process or if you do
not intend you're at on to be translated (it you should have a
very good reason you cannot translate if so) let us know but
otherwise you should translate your ad on. We will check in the
review process and let you know if there are any things that you
can do to ensure you're at on is successful with translations.
Sent from a mobile device.
Please disregard errors as this is a smaller device.
On Jun 19, 2016, at 09:35, Iguatemi Garin <iguatemi@xxxxxxxxxx>
wrote:
Hi.
I'd like to ask for a new review on the Emotisounds addon.
Besides updating the repo, what else is necessary?
Thank you all!
Iguatemi Garin
http://hadrons.io
--
------------------------------------------------------------------------
Derek Riemer
* Department of computer science, third year undergraduate student.
* Proud user of the NVDA screen reader.
* Open source enthusiast.
* Member of Bridge Cu
* Avid skiier.
Websites:
Honors portfolio <http://derekriemer.com>
Awesome little hand built weather app! <http://django.derekriemer.com/weather/>
email me at derek.riemer@xxxxxxxxxxxx <mailto:derek.riemer@xxxxxxxxxxxx>
Phone: (303) 906-2194
