[nvda-addons] Re: Addon for MS access code review
- From: "Joseph Lee" <joseph.lee22590@xxxxxxxxx>
- To: <nvda-addons@xxxxxxxxxxxxx>
- Date: Mon, 16 Jun 2014 18:08:16 -0700
Hi,
Your solution works as expected in Office 2010.
A small request: would you like to maintain Microsoft Access app module?
A few things though:
* In scripts, we usually use the name "gesture" for the second argument.
* I think docstrings might not be needed to explain all functions, as a one
liner might be sufficient.
* It might be preferable to split objects into their own overlay class (such
as access cell, access table, etc.) for easier debugging and maintenance.
* Aren't Shift+Right arrow, up arrow and f3 native Access commands? If so,
I'd recommend using a different gestures to minimize conflict and to pass on
as much native gestures as possible to Access.
At least you've started well. Keep up the good work.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Dylan Neale
Sent: Monday, June 16, 2014 5:44 PM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Addon for MS access code review
Hi
I've attached the file, since I don't have a bitbucket or github account
yet.
On Tue, Jun 17, 2014 at 12:28 PM, Joseph Lee <joseph.lee22590@xxxxxxxxx>
wrote:
>
> Hello,
>
> Please send the code (the py file) as an attachment to this list, or if
you have Github or Bitbucket, please tell us where to get your code so we
can fork it and give you code review.C
>
> Cheers,
>
> Joseph
>
>
>
> From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Dylan Neale
> Sent: Monday, June 16, 2014 4:52 PM
> To: nvda-addons@xxxxxxxxxxxxx
> Subject: [nvda-addons] Addon for MS access code review
>
>
>
> Hi
>
> This is my first attempt at improving an addon for NVDA, and most of the
code was already written. I have made some changes, and would like to get
these reviewed before submitting them to the repo.
>
> What I've done so far is quite hacky, mainly because I'm not aware of all
the NVDA functions yet. It works with access 2013, but not sure about
others.
>
> Do I email the code to this list for review/comments or submit it
somewhere else?
>
> Thanks.
----------------------------------------------------------------
NVDA add-ons Central: A list for discussing NVDA add-ons
To post a message, send an email to nvda-addons@xxxxxxxxxxxxx.
To unsubscribe, send an email with the subject line of "unsubscribe" (without
quotes) to nvda-addons-request@xxxxxxxxxxxxx.
If you have questions for list moderators, please send a message to
nvda-addons-moderators@xxxxxxxxxxxxx.
Community addons can be found here: http://addons.nvda-project.org
Other related posts:
