commit/wintenApps: josephsl: WinTenObjs: detect Windows 10 in overlay class chooser and return immediately if an earlier Windows release is in use.

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: commits+int+220+6085746285340533186@xxxxxxxxxxxxxxxxxxxxx, nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Sun, 17 Feb 2019 04:13:14 +0000 (UTC)

1 new commit in wintenApps:

https://bitbucket.org/nvdaaddonteam/wintenapps/commits/4b2a8d33dea0/
Changeset:   4b2a8d33dea0
Branch:      stable
User:        josephsl
Date:        2019-02-17 04:12:50+00:00
Summary:     WinTenObjs: detect Windows 10 in overlay class chooser and return 
immediately if an earlier Windows release is in use.

Reported by a user and subsequently confirmed: if one uses this add-on on a 
Windows 7 or 8.1 computer, NVDA keeps playing error tones while using Windows 
Explorer. Turns out a COM error from overlay class chooser is to blame, so 
detect it early and return immediately if the Windows release isn't Windows 10 
at all (at the top of the function body).

Affected #:  1 file

diff --git a/addon/globalPlugins/wintenObjs/__init__.py 
b/addon/globalPlugins/wintenObjs/__init__.py
index a7a59a5..5b693ed 100755
--- a/addon/globalPlugins/wintenObjs/__init__.py
+++ b/addon/globalPlugins/wintenObjs/__init__.py
@@ -140,6 +140,8 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
                        
UIAHandler.handler.clientObject.AddPropertyChangedEventHandler(UIAHandler.handler.rootElement,TreeScope_Subtree,UIAHandler.handler.baseCacheRequest,UIAHandler.handler,[UIAHandler.UIA_ItemStatusPropertyId])
 
        def chooseNVDAObjectOverlayClasses(self, obj, clsList):
+               # Because this add-on might be turned on "accidentally" in 
earlier Windows releases...
+               if winVersion.winVersion.major < 10: return
                if isinstance(obj, UIA):
                        # NVDA Core ticket 5231: Announce values in time 
pickers, especially when focus moves to looping selector list.
                        # Because they do not support value pattern (for ones 
handled by this add-on), treat them as combo boxes without value pattern if 
this isn't treated as such by NVDA already.

Repository URL: https://bitbucket.org/nvdaaddonteam/wintenapps/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts:

  • » commit/wintenApps: josephsl: WinTenObjs: detect Windows 10 in overlay class chooser and return immediately if an earlier Windows release is in use. - commits-noreply