commit/placeMarkers: norrumar: When moving to a bookmark from the Notes dialog, the review cursor doesn't follow system cursor

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: commits+int+220+6085746285340533186@xxxxxxxxxxxxxxxxxxxxx, nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Thu, 06 Jul 2017 17:55:33 +0000 (UTC)

1 new commit in placeMarkers:

https://bitbucket.org/nvdaaddonteam/placemarkers/commits/2f8f9db75521/
Changeset:   2f8f9db75521
Branch:      i6
User:        norrumar
Date:        2017-07-06 17:44:00+00:00
Summary:     When moving to a bookmark from the Notes dialog, the review cursor 
doesn't follow system cursor

Instead of using info.updateCaret(), when possible, set object.selection = info.

Affected #:  2 files

diff --git a/addon/globalPlugins/placeMarkers/__init__.py 
b/addon/globalPlugins/placeMarkers/__init__.py
index 5d2995e..25dbd3b 100644
--- a/addon/globalPlugins/placeMarkers/__init__.py
+++ b/addon/globalPlugins/placeMarkers/__init__.py
@@ -114,7 +114,10 @@ def moveToBookmark(position):
                        obj=treeInterceptor
                info = obj.makeTextInfo(textInfos.POSITION_FIRST)
                info.move(textInfos.UNIT_CHARACTER, position)
-               info.updateCaret()
+               if hasattr(obj,'selection'):
+                       obj.selection=info
+               else:
+                       info.updateCaret()
                speech.cancelSpeech()
                info.move(textInfos.UNIT_LINE,1,endPoint="end")
                speech.speakTextInfo(info,reason=controlTypes.REASON_CARET)

diff --git a/buildVars.py b/buildVars.py
index 964d185..c144936 100755
--- a/buildVars.py
+++ b/buildVars.py
@@ -19,7 +19,7 @@ addon_info = {
        # Translators: Long description to be shown for this add-on on add-on 
information from add-ons manager
        "addon_description" : _("Add-on for setting place markers on specific 
virtual documents"),
        # version
-       "addon_version" : "8.0",
+       "addon_version" : "9.0-dev-i6",
        # Author(s)
        "addon_author" : u"Noelia <nrm1977@xxxxxxxxx>, Chris 
<llajta2012@xxxxxxxxx>",
        # URL for the add-on documentation support

Repository URL: https://bitbucket.org/nvdaaddonteam/placemarkers/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts:

  • » commit/placeMarkers: norrumar: When moving to a bookmark from the Notes dialog, the review cursor doesn't follow system cursor - commits-noreply