commit/StationPlaylist: josephsl: Project Starfish (6.0-dev): Do not assume that we can interupt the show by using the real config store while starfish is changing its arms

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Thu, 04 Jun 2015 20:43:46 -0000

1 new commit in StationPlaylist:

https://bitbucket.org/nvdaaddonteam/stationplaylist/commits/cc32f1738229/
Changeset: cc32f1738229
Branch: 6.0/broadcastProfile
User: josephsl
Date: 2015-06-04 20:43:15+00:00
Summary: Project Starfish (6.0-dev): Do not assume that we can interupt the
show by using the real config store while starfish is changing its arms

During profile selection, do not let NVDA interupt the show by changing
SPLConfig settings. Instead, a temporary config store will be used to get
settings values from appropriate profile.

Affected #: 1 file

diff --git a/addon/appModules/splstudio/splconfig.py
b/addon/appModules/splstudio/splconfig.py
index 227f3e5..f622c6a 100755
--- a/addon/appModules/splstudio/splconfig.py
+++ b/addon/appModules/splstudio/splconfig.py
@@ -325,11 +325,11 @@ class SPLConfigDialog(gui.SettingsDialog):
def onProfileSelection(self, evt):
import tones
tones.beep(500, 100)
- global SPLConfig
- SPLConfig = SPLConfigPool[self.profiles.GetSelection()]
- self.beepAnnounceCheckbox.SetValue(SPLConfig["BeepAnnounce"])
- self.outroCheckBox.SetValue(SPLConfig["SayEndOfTrack"])
- self.endOfTrackAlarm.SetValue(long(SPLConfig["EndOfTrackTime"]))
+ # Don't rely on SPLConfig here, as we don't want to interupt
the show.
+ selectedProfile = SPLConfigPool[self.profiles.GetSelection()]
+
self.beepAnnounceCheckbox.SetValue(selectedProfile["BeepAnnounce"])
+ self.outroCheckBox.SetValue(selectedProfile["SayEndOfTrack"])
+
self.endOfTrackAlarm.SetValue(long(selectedProfile["EndOfTrackTime"]))
self.onOutroCheck(None)

# Reset settings to defaults.

Repository URL: https://bitbucket.org/nvdaaddonteam/stationplaylist/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts:

  • » commit/StationPlaylist: josephsl: Project Starfish (6.0-dev): Do not assume that we can interupt the show by using the real config store while starfish is changing its arms - commits-noreply