commit/StationPlaylist: josephsl: Forgot to rename the elapsed time variable; code cleanup.

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Sun, 23 Mar 2014 13:35:32 -0000

1 new commit in StationPlaylist:

https://bitbucket.org/nvdaaddonteam/stationplaylist/commits/36f177071fb2/
Changeset:   36f177071fb2
Branch:      master
User:        josephsl
Date:        2014-03-23 14:35:13
Summary:     Forgot to rename the elapsed time variable; code cleanup.

Affected #:  2 files

diff --git a/addon/appModules/splstudio.py b/addon/appModules/splstudio.py
index 829d3f3..e699768 100644
--- a/addon/appModules/splstudio.py
+++ b/addon/appModules/splstudio.py
@@ -170,12 +170,12 @@ class AppModule(appModuleHandler.AppModule):
 
        def script_sayElapsedTime(self, gesture):
                # Quite a complicated expression there.
-               remainingTime = 
self.getStatusChild(self.SPLElapsedTime).children[1].name if self.SPLCurVersion 
>= SPLMinVersion else self.getStatusChild(self.SPL4ElapsedTime).children[0].name
-               ui.message(remainingTime)
+               elapsedTime = 
self.getStatusChild(self.SPLElapsedTime).children[1].name if self.SPLCurVersion 
>= SPLMinVersion else self.getStatusChild(self.SPL4ElapsedTime).children[0].name
+               ui.message(elapsedTime)
        # Translators: Input help mode message for a command in Station 
Playlist Studio.
        script_sayElapsedTime.__doc__=_("Announces the elapsed time for the 
currently playing track.")
 
-       # Set the end of track alarm time between 1 and 9 seconds.
+       # Set the end of track alarm time between 1 and 59 seconds.
 
        def script_setEndOfTrackTime(self, gesture):
                # Borrowed from NVDA core cursorManager.py.
@@ -200,7 +200,8 @@ class AppModule(appModuleHandler.AppModule):
                                        else: newAlarmSec = dlg.GetValue()
                                        self.SPLEndOfTrackTime = 
self.SPLEndOfTrackTime.replace(self.SPLEndOfTrackTime[-2:], newAlarmSec) # 
Quite a complicated replacement expression, but it works in this case.
                gui.runScriptModalDialog(dlg, callback)
-       script_setEndOfTrackTime.__doc__="sets end of track alarm (default is 5 
seconds)."
+       # Translators: Input help mode message for a command in Station 
Playlist Studio.
+       script_setEndOfTrackTime.__doc__=_("sets end of track alarm (default is 
5 seconds).")
 
        # Toggle whether beeps should be heard instead of toggle announcements.
 
@@ -226,7 +227,6 @@ class AppModule(appModuleHandler.AppModule):
                # Do some optimization later (techniques will include a bit of 
memoization using a cache dictionary of searched texts).
                while obj is not None:
                        if text in obj.description:
-                               # We need to fire set focus event twice and 
exit this routine.
                                self.findText = text
                                # We need to fire set focus event twice and 
exit this routine.
                                obj.setFocus(), obj.setFocus()

diff --git a/addon/globalPlugins/SPLStudioUtils.py 
b/addon/globalPlugins/SPLStudioUtils.py
index 2b77e71..4df66bc 100644
--- a/addon/globalPlugins/SPLStudioUtils.py
+++ b/addon/globalPlugins/SPLStudioUtils.py
@@ -75,7 +75,6 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
 
        def fetchSPLForegroundWindow(self):
                # Let us see if SPL foreground can be fetched.
-               import NVDAObjects
                # First test: is splstudio running? Tell me the handle, please.
                if user32.FindWindowA("SPLStudio", None) == 0: return None # 
Used ANSI version, as Wide char version always returns 0.
                # Continue with the method.

Repository URL: https://bitbucket.org/nvdaaddonteam/stationplaylist/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts:

  • » commit/StationPlaylist: josephsl: Forgot to rename the elapsed time variable; code cleanup. - commits-noreply