commit/StationPlaylist: 2 new changesets

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Thu, 24 Nov 2016 22:48:45 -0000

2 new commits in StationPlaylist:

https://bitbucket.org/nvdaaddonteam/stationplaylist/commits/1f92a6e750ee/
Changeset:   1f92a6e750ee
Branch:      None
User:        josephsl
Date:        2016-11-19 05:16:42+00:00
Summary:     16.12/15.4-LTS: exclude cart edit/insert toggle from toggle 
announcement routine. fixes #14.

Because cart edit mode status also displays cart insert state, exclude this 
text from being processed by toggle announcement routine. This fixes issues 
such as same rising tone being heard when toggling cart edit mode (Control+T) 
when cart insert mode is active (this is the case even for advanced verbosity 
mode).
This is destined for 16.12 and 15.4-LTS.

Affected #:  1 file

diff --git a/addon/appModules/splstudio/__init__.py 
b/addon/appModules/splstudio/__init__.py
index a4312f0..b2f7ce2 100755
--- a/addon/appModules/splstudio/__init__.py
+++ b/addon/appModules/splstudio/__init__.py
@@ -715,7 +715,8 @@ class AppModule(appModuleHandler.AppModule):
                                        if self.libraryScanning: 
self.libraryScanning = False
                                        self.scanCount = 0
                        else:
-                               if obj.name.endswith((" On", " Off")):
+                               # 16.12: Because cart edit text shows cart 
insert status, exclude this from toggle state announcement.
+                               if obj.name.endswith((" On", " Off")) and not 
obj.name.startswith("Cart "):
                                        self._toggleMessage(obj.name)
                                else:
                                        ui.message(obj.name)


https://bitbucket.org/nvdaaddonteam/stationplaylist/commits/886f75132dc4/
Changeset:   886f75132dc4
Branch:      stable
User:        josephsl
Date:        2016-11-19 23:58:53+00:00
Summary:     16.12/15.4-LTS: never allow comments to be added to timed break 
notes.

Timed break notes display a different name for filename (integers followed by a 
colon), potentially confusing users. Therefore prevent comments from being 
added to these (a manual intervention is required, in that comments should be 
erased).

Affected #:  1 file

diff --git a/addon/appModules/splstudio/__init__.py 
b/addon/appModules/splstudio/__init__.py
index b2f7ce2..1a4b1c3 100755
--- a/addon/appModules/splstudio/__init__.py
+++ b/addon/appModules/splstudio/__init__.py
@@ -327,7 +327,8 @@ class SPLTrackItem(IAccessible):
                                # Translators: Presented when there is no track 
comment for the focused track.
                                ui.message(_("No comment"))
                        elif level >= 3:
-                               if filename is not None:
+                               # 16.12: timed break notes shows an odd value 
for filename (seconds in integers followed by a colon), potentially confusing 
users.)
+                               if filename and not filename.endswith(":"):
                                        self._trackCommentsEntry(filename, "")
                                else:
                                        # Translators: Presented when focused 
on a track other than an actual track (such as hour marker).

Repository URL: https://bitbucket.org/nvdaaddonteam/stationplaylist/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts: