Re: [Patch v3 06/11] test/thread-naming: remove excess escaping from sender address.

  • From: Tomi Ollila <tomi.ollila@xxxxxx>
  • To: David Bremner <david@xxxxxxxxxxx>, notmuch@xxxxxxxxxxxxx, notmuch@xxxxxxxxxxxxxxx
  • Date: Tue, 30 May 2017 00:09:59 +0300

On Sat, May 27 2017, David Bremner wrote:

This is another case where the behaviour of gmime-2.6 and gmime-3.0
seems to differ. It may be that we prefer the more lax parsing of the
previous version, but that should be tested seperately.

This series lgtm (afaiu) so far, but s/seper/separ/ above. In 04/11 `shuf`
adds to coreutils dependencies, but that is in perf test...

---
 test/T200-thread-naming.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/T200-thread-naming.sh b/test/T200-thread-naming.sh
index 132c1d77..2167ba8e 100755
--- a/test/T200-thread-naming.sh
+++ b/test/T200-thread-naming.sh
@@ -66,11 +66,11 @@ test_expect_equal "$output" "thread:XXX   2001-01-12 
[6/8] Notmuch Test Suite; t
 test_begin_subtest "Use empty subjects if necessary."
 add_message '[subject]="@FORCE_EMPTY"' \
          '[date]="Sat, 13 Jan 2001 15:43:45 -0000"' \
-            '[from]="Empty Sender \<empty_test@xxxxxxxxxxxxxxx\>"'
+            '[from]="Empty Sender <empty_test@xxxxxxxxxxxxxxx>"'
 empty_parent=${gen_msg_id}
 add_message '[subject]="@FORCE_EMPTY"' \
          '[date]="Sun, 14 Jan 2001 15:43:45 -0000"' \
-            '[from]="Empty Sender \<empty_test@xxxxxxxxxxxxxxx\>"' \
+            '[from]="Empty Sender <empty_test@xxxxxxxxxxxxxxx>"' \
             "[in-reply-to]=\<$empty_parent\>"
 output=$(notmuch search --sort=newest-first from:empty_test@xxxxxxxxxxxxxxx 
| notmuch_search_sanitize)
 test_expect_equal "$output" "thread:XXX   2001-01-14 [2/2] Empty Sender;  
(inbox unread)"
@@ -78,15 +78,15 @@ test_expect_equal "$output" "thread:XXX   2001-01-14 
[2/2] Empty Sender;  (inbox
 test_begin_subtest "Avoid empty subjects if possible (newest-first)."
 add_message '[subject]="Non-empty subject (1)"' \
          '[date]="Mon, 15 Jan 2001 15:43:45 -0000"' \
-            '[from]="Empty Sender \<empty_test@xxxxxxxxxxxxxxx\>"' \
+            '[from]="Empty Sender <empty_test@xxxxxxxxxxxxxxx>"' \
             "[in-reply-to]=\<$empty_parent\>"
 add_message '[subject]="Non-empty subject (2)"' \
          '[date]="Mon, 16 Jan 2001 15:43:45 -0000"' \
-            '[from]="Empty Sender \<empty_test@xxxxxxxxxxxxxxx\>"' \
+            '[from]="Empty Sender <empty_test@xxxxxxxxxxxxxxx>"' \
             "[in-reply-to]=\<$empty_parent\>"
 add_message '[subject]="@FORCE_EMPTY"' \
          '[date]="Tue, 17 Jan 2001 15:43:45 -0000"' \
-            '[from]="Empty Sender \<empty_test@xxxxxxxxxxxxxxx\>"' \
+            '[from]="Empty Sender <empty_test@xxxxxxxxxxxxxxx>"' \
             "[in-reply-to]=\<$empty_parent\>"
 output=$(notmuch search --sort=newest-first from:Empty | 
notmuch_search_sanitize)
 test_expect_equal "$output" "thread:XXX   2001-01-17 [5/5] Empty Sender; 
Non-empty subject (2) (inbox unread)"
-- 
2.11.0

Other related posts:

  1. Home
  2. notmuch
  3. Archive
  4. 05-2017