Re: [PATCH 16/23] cli: generalize use of GMIME_SIGNATURE_{ERROR,STATUS} to gmime-3

From: Daniel Kahn Gillmor <dkg@xxxxxxxxxxxxxxxxx>
To: David Bremner <david@xxxxxxxxxxx>, notmuch@xxxxxxxxxxxxxxx, notmuch@xxxxxxxxxxxxx
Date: Fri, 07 Jul 2017 18:18:55 -0400

On Sat 2017-06-03 14:47:47 -0300, David Bremner wrote:

@@ -376,6 +376,33 @@ format_signature_errors (sprinter_t *sp, GMimeSignature
*signature)

     do_format_signature_errors (sp, key_map, ARRAY_SIZE(key_map), errors);
}
+#else
+static void
+format_signature_errors (sprinter_t *sp, GMimeSignature *signature)
+{
+    GMimeSignatureError errors = g_mime_signature_get_errors (signature);
+
+    if (!(errors & GMIME_SIGNATURE_STATUS_ERROR_MASK))
+     return;
+
+    struct {
+     GMimeSignatureStatus bit;
+     const char * string;
+    } key_map[] = {

I think this should be:

struct key_map_struct key_map

rather than an anonymous struct.

--dkg

Re: [PATCH 16/23] cli: generalize use of GMIME_SIGNATURE_{ERROR,STATUS} to gmime-3

Other related posts: