Mark Walters <markwalters1009@xxxxxxxxx> writes:
On Tue, 09 May 2017, David Bremner <david@xxxxxxxxxxx> wrote:
There are two keyword options here that impliment boolean options. It
is simpler to use the built-in boolean argument handling, and also
more robust against divergence in parsing boolean and keyword arguments.
Hi
Surely some case must go wrong for entire-thread? I think perhaps
notmuch-show --format=json --entire-thread=false <search-terms> will
still give the whole thread? (I can't easily test right now)
If I am reading the code right we are comparing the return value of the
boolean option (TRUE/FALSE) with the enum value for
ENTIRE_THREAD_DEFAULT/TRUE/FALSE.
Perhaps it would work if we reordered
the enum with ENTIRE_THREAD_DEFAULT last.