[nanomsg] Re: [PATCH] Initialize epbase item

  • From: Martin Sustrik <sustrik@xxxxxxxxxx>
  • To: nanomsg@xxxxxxxxxxxxx
  • Date: Mon, 04 Mar 2013 18:47:30 +0100

Hi Nir,
The patch is now applied. I've modified it a bit so that epbase explicitly tests whether it is not yet attached to any socket. I believe the code is easier to follow that way. 

Thanks!
Martin

On 03/03/13 12:20, Nir Soffer wrote:

This patch is also MIT licensed.

On Sat, Mar 2, 2013 at 5:08 AM, Nir Soffer <nirsof@xxxxxxxxx
<mailto:nirsof@xxxxxxxxx>> wrote:

    epbase nn_list_item struct was not initialized, leading to failures when
    an item was removed from a list before it was added to the list.

    Now nn_epbase_init() initialize the item to nill item.

    In nn_list_item_nil(), only prev pointer was initialized. Now next
    pointer is initialized as well.

    This fix the "Conditional jump or move depends on uninitialised
    value(s)" error seen in valgrind in the tcp test.

Other related posts:

  1. Home
  2. nanomsg
  3. Archive
  4. 03-2013