[muscle] Re: Another Java MUSCLE client patch
- From: Jeremy Friesner <jaf@xxxxxxxxxxxx>
- To: Lior Okman <lior.okman@xxxxxxxxxxxxxxxxxx>
- Date: Thu, 11 Jan 2007 15:29:14 -0800
Hi Lior,
Thanks for the fixes; I've updated the SVN tree and uploaded a new
muscle3.30b.zip reflecting them (to the same URL as before).
-Jeremy
On Thursday 11 January 2007 15:00, Lior Okman wrote:
> I'm looking at the zip file you sent me a link to, and
>
> 1. The HISTORY.txt file is wrong - only the flatten() method is faster,
> since unflatten() didn't call flattenedSize() to begin with.
> 2. You should probably also note that one of the changes (the one where
> Enumerations turned to Iterators) cause the new Message object to lose
> backwards compatibility - any code calling Message.fieldNames() needs to
> be updated. Unfortunately, return values can't be overloaded.
> 3. Another cleanup patch to the Message class, to use the
> fieldItemSize() method, instead of hardcoding the field sizes in
> flatten() and unflatten() for MessageFields.
> 4. Removed an extra call to flattenedSize() in JZLibMessageIOGateway.
> 5. Also, a patch to the java's build.xml file, to update the version
> number that is written in the manifest.mf file when the build.xml file
> is used to generate a muscle.jar file.
>
> Regards,
> Lior
Other related posts:
