[liblouis-liblouisxml] Re: [liblouis/liblouis] 3c62a6: Added indian tables by sreeja.param@xxxxxxxxx

  • From: Mesar Hameed <mesar.hameed@xxxxxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Thu, 4 Sep 2014 11:40:09 +0100

Hi, all,

In addition to what Christian already stated, we would appreciate that
when you do use pull requests, that they are small and concise.
i.e. one pull request per table, not one massive one with lots of
languages/tables.

Best wishes,
Mesar 

On Thu 04/09/14,09:16, Christian Egli wrote:
> Hi all
> 
> On 09/04/2014 08:10 AM, sreeja pam wrote:
> >Hello Christin, Mesar,
> >Thank you so much for including our liblouis tables in this release. I
> >just downloaded liblouis2.6.0 and found that our tables are there!..
> >Thanks for all your assistance and help. We are working on the process
> >of testing. Will get back to you soon after collecting words from
> >different languages.
> 
> Well, the good news is that we managed to include the tables. The bad news
> is that we had to revert the changes in the Tamil tables because they did
> break existing automated tests for Tamil (see 
> https://github.com/liblouis/liblouis/blob/master/tests/harness/ta-ta-g1_harness.txt).
> 
> 
> So please for the next release make sure to work with us by making sure:
> 
> - Create test data for automated tests
> - fork on github and apply your patches to your fork
> - Create a pull request so that we can merge your changes easily
> - Fix the problems with either the Tamil table or the test data
> 
> Thanks
> Christian
> 
> -- 
> Christian Egli
> Swiss Library for the Blind, Visually Impaired and Print Disabled
> Grubenstrasse 12, CH-8045 Zürich, Switzerland
> 
> For a description of the software, to download it and links to
> project pages go to http://www.abilitiessoft.com

Attachment: signature.asc
Description: Digital signature

Other related posts: