[liblouis-liblouisxml] [liblouis/liblouis] 2156d2: Fix the random behaviour in the typeform tests

  • From: Christian Egli <christian.egli@xxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Tue, 04 Aug 2015 07:29:30 -0700

Branch: refs/heads/feature/yaml_tests
Home: https://github.com/liblouis/liblouis
Commit: 2156d2dd9ab81d5a95806e2eaac2836d6ce5d0c4

https://github.com/liblouis/liblouis/commit/2156d2dd9ab81d5a95806e2eaac2836d6ce5d0c4
Author: Christian Egli <christian.egli@xxxxxx>
Date: 2015-08-04 (Tue, 04 Aug 2015)

Changed paths:
M liblouis/lou_translateString.c
M liblouis/transcommon.ci
M tests/Makefile.am
M tests/en-ueb-g1_harness.yaml

Log Message:
-----------
Fix the random behaviour in the typeform tests

There is now a safe version of the checkAttr function which makes sure
that no attributes are checked beyond the boundaries of the
currentInput. This fixes the random behavior with tests where the
emphasis extends to the end of the input string.

All the yaml tests (with the exception of one) have been re-enabled as
they no longer produce random results now.

Strangely this bug seems never to have been exposed to the language
bindings.


Commit: 9dcb78215d299761ed590b535f57fd9913c623d0

https://github.com/liblouis/liblouis/commit/9dcb78215d299761ed590b535f57fd9913c623d0
Author: Christian Egli <christian.egli@xxxxxx>
Date: 2015-08-04 (Tue, 04 Aug 2015)

Changed paths:
M liblouis/lou_translateString.c
M tests/Makefile.am

Log Message:
-----------
Fix more random behavior in the braille indicator handling

which was exposed in the Tamil harness tests.

This is yet another lovely example of out-of-bounds array access on
currentInput. Fixed with the help of checkAttr_safe.


Compare:
https://github.com/liblouis/liblouis/compare/2b7d0964acbc...9dcb78215d29

Other related posts:

  • » [liblouis-liblouisxml] [liblouis/liblouis] 2156d2: Fix the random behaviour in the typeform tests - Christian Egli