[liblouis-liblouisxml] Re: bug in logging.c

  • From: Lars Bjørndal <lars@xxxxxxxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Mon, 25 Jan 2016 11:20:30 +0100

Hi, Christian!

Are you able to compile liblouisutdml on Linux? I pulled right now,
and tried, but the make process failed with:

logging.c:130:1: error: conflicting types for 'defaultLogCallback'
defaultLogCallback (logLevels level, const char *message)
^
logging.c:63:13: note: previous declaration of 'defaultLogCallback'
was here
static void defaultLogCallback(int level, const char *message);
^
logging.c:63:13: warning: 'defaultLogCallback' used but
never defined
Makefile:834: recipe for target 'liblouisutdml_la-logging.lo' failed
make[2]: *** [liblouisutdml_la-logging.lo] Error 1
make[2]: Leaving directory
'/home/lrs/tmp/liblouisutdml/liblouisutdml'
Makefile:658: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory
'/home/lrs/tmp/liblouisutdml/liblouisutdml'
Makefile:700: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1


Thanks and regards,
Lars


On Mon, Jan 25, 2016 at 10:39:31AM +0100, Christian Egli wrote:

Hi Neil

Neil Soiffer <NeilS@xxxxxxxxxx> writes:

I'm working on updating MathPlayer on Windows (under Visual Studio
2015) to use the latest releases of LibLouis and LibLouisUTDML. I
found the following problem in logging.c:

Thanks for reporting this problem. I (finally) fixed it in both liblouis
and liblouisutdml.

Also, for debugging, it would be better for make_makefile.c to have
these lines for CCFLAGS that turn on debugging info for a debug build:
"CCFLAGS = $(CCFLAGS) /nologo $(INCLUDES) /W1 /c /DLBULIB
/DLIBXML_STATIC",
"!ifdef DEBUG",
"CCFLAGS = $(CCFLAGS) /Zi",
"!else",
"CCFLAGS = $(CCFLAGS) /O2",
"!endif",

AFAIK this is very specific to liblouisutdml and msvc. Since I use
neither I do not feel very comfortable applying this. Can maybe some of
the affected users tell me that this change is the right thing to do?

Thanks
Christian

--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland

-----
Jetzt kostenlos bestellen: Eidgenoessische und kantonale
Abstimmungsunterlagen fuer den 28. Februar zum Hoeren auf CD. Bestellungen an
medienverlag@xxxxxx
For a description of the software, to download it and links to
project pages go to http://liblouis.org

For a description of the software, to download it and links to
project pages go to http://liblouis.org

Other related posts: