Hello,
Just thought I'd be nuisance and point out that identifiers that start
with a leading underscore are actually reserved by the standard[1],
i.e. see the ISO/IEC C9899 standard section 7.1.3. While it's highly
unlikely that this will ever create a problem it means that liblouis
code-base NOT valid C89/99[2].
Yeah, I know, but these kind of things kinda trigger my OCD! Also,
relevant quote from Futurama:
"Bureaucrat Conrad, you are technically correct -- the best kind of correct."
-- Number 1.0 (a.k.a. The head of bureaucracy)
Best,
Simon
[1]: The exact wording is (or at least latest draft wording): " All
identifiers that begin with an underscore are always reserved for use
as identifiers
with file scope in both the ordinary and tag name spaces."
On 20 June 2017 at 13:44, Christian Egli <christian.egli@xxxxxx> wrote:
Hammer Attila <hammera@xxxxxxxxx> writes:For a description of the software, to download it and links to
I upgraded Liblouis with 3.2.0 release and try again compile with
Liblouisutdml latest development source tree to see this version
working good the liblouisutdml building.
The compilation is terminated with following error my build machine:
"In file included from change_table.c:34:0:
louisutdml.h:36:19: fatal error: louis.h: no such file or directory"
If I see right, the Liblouis 3.2.0 release source tree not containing
louis.h include file in the liblouis directory.
If the 3.2.0 or future Liblouis releases the louis.h is not need,
possible fixing this issue in Liblouisutdml?
Well, I guess I should have mentioned this in the NEWS file. In order to
make it more clear that the funtions in louis.h are part of the internal
API we renamed louis.h to internal.h. Also the functions have been
prepended with an underscore to make it even more clear that these are
internal funtions.
liblouisutdml uses this internal API. So unfortunately you will have to
change liblouisutdml to make it compile with liblouis 3.2.
Maybe this was a bit overzealous on our part. I hope we can resolve this
for liblouisutdml.
Hope that helps
Christian
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
-----
Tag der offenen Tuer "Eine Reise durch die Schweiz"
Die SBS laedt Sie herzlich ein: 24. Juni 2017 von 9 bis 16 Uhr.
Mehr Informationen erhalten Sie unter www.sbs.ch/offenetuer
For a description of the software, to download it and links to
project pages go to http://liblouis.org
